Add weak pointer handling #3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using `WeakPtrFactory`, and add comments reminding about the need for the same in any new derived classes.
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3763-compared-to-main.txt |
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3763-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3763-compared-to-legacy.txt |
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3763-compared-to-main.txt |
louwers
approved these changes
Sep 2, 2025
TimSylvester
added a commit
to WetDogWeather/maplibre-gl-native
that referenced
this pull request
Sep 3, 2025
* main: Create macOS amalgamation for core releases (maplibre#3768) Add weak pointer handling (maplibre#3763) Temporarily disable Windows CI (maplibre#3775) chore(ci): pin actions to shas (maplibre#3769) Fix compile error when building with MLN_USE_TRACY (maplibre#3774) set MLN_WITH_OPENGL=OFF by default, like Metal/Vulkan (maplibre#3772) Tweak Linux amalgamation (maplibre#3767) Tweak layer depth distribution (maplibre#3738) Add Sentry build tags (maplibre#3765) Release MapLibre Android 11.13.1 (maplibre#3761) Release MapLibre iOS 6.18.1 (maplibre#3762) Add weak pointer management to RasterSource and derived classes (maplibre#3726) Fix UB in TaggedString constructor (maplibre#3748) Add Compose Multiplatform section to README (maplibre#3751) format Bazel files with buildifier (maplibre#3756) use separate install-sccache script (maplibre#3755) Fix Android backend cleanup (maplibre#3681) # Conflicts: # include/mbgl/style/sources/raster_dem_source.hpp # include/mbgl/style/sources/vector_source.hpp # platform/ios/BUILD.bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add weak pointer handling and
finalto all the most-derived classes usingWeakPtrFactory, and add comments reminding about the need for the same in any new derived classes.Follow-up to #3726
Resolves #3758