Frustum Offset Proposal #3676

yousifd · 2025-07-29T10:05:37Z

This PR adds the following:

Exposes a frustumOffset property in iOS and Android that allows a user to specify how much of the edges of the screen is out of view and shouldn't be rendered in logical pixel units.
Modifies the projection matrix computation to compute the fov with a top offset from the provided frustumOffset property.
Modifies the Metal, OpenGL, and Vulkan renderers to apply a scissor test given the frustumOffset to reject fragments at the edges of the screen which might be behind UI elements.

…ustum

…ngl and vulkan

github-actions · 2025-07-29T11:11:12Z

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +17.1Ki  +0.2% +32.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3676-compared-to-main.txt

github-actions · 2025-07-29T11:22:07Z

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +13.6Ki  +0.0% +5.16Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3676-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +33% +38.2Mi  +448% +26.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3676-compared-to-legacy.txt

github-actions · 2025-07-29T11:26:00Z

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0130         -0.0127             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3676-compared-to-main.txt

src/mbgl/vulkan/pipeline.cpp

adrian-cojocaru · 2025-07-29T14:01:26Z

include/mbgl/map/map_options.hpp

+     * @param offset_ A set of edge insets in logical pixels.
+     * @return reference to MapOptions for chaining options together.
+     */
+    MapOptions& withFrustumOffset(const EdgeInsets& offset_);


Using MapOptions::withFrustumOffset for static setup sounds like a worse option than resizing the draw surface to match the content. I think Map::setFrustumOffset handles all use cases and encourages dynamic updates (when needed).

But what if you need to draw to a larger area layer?

In that case I'd think that most people would solve it via composition instead of searching for this specific option. If withFrustumOffset is used the color and depth attachments are still allocated to the full size. My point is it's not the most intuitive option for static layouts and if you still need it you can use Map::setFrustumOffset.

…ap options

louwers · 2025-08-06T14:24:26Z

platform/ios/src/MLNMapView.h

+/**
+ Frustum offset used to disable rendering of elements at the edge of the screen
+
+ Offset applied to camera frustum and scissor rectangle. The camrea frustum is modofied


Suggested change

Offset applied to camera frustum and scissor rectangle. The camrea frustum is modofied

Offset applied to camera frustum and scissor rectangle. The camrea frustum is modified

louwers · 2025-08-06T14:25:48Z

platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/maps/MapLibreMap.java

@@ -117,6 +117,13 @@ public void enableRenderingStatsView(boolean value) {
    nativeMapView.enableRenderingStatsView(value);
  }

+  /**
+   * Set frustum offset to disable rendering for edges of the screen


Maybe you could make the documentation comments similar for iOS and Android.

louwers · 2025-08-06T14:27:27Z

src/mbgl/gfx/scissor_rect.hpp

+
+class ScissorRect {
+public:
+    int32_t x, y;


Please put these on their own lines.

louwers · 2025-08-06T14:28:29Z

src/mbgl/gfx/scissor_rect.hpp

+    int32_t x, y;
+    uint32_t width, height;
+
+    bool operator==(const ScissorRect& other) const {


Since we are using C++20 I think we can use = default now for both operator== and operator!=. https://en.cppreference.com/w/cpp/language/default_comparisons.html

louwers · 2025-08-06T14:28:40Z

src/mbgl/gfx/scissor_rect.hpp

+class ScissorRect {
+public:
+    int32_t x, y;
+    uint32_t width, height;


Please put on individual lines.

louwers

Please consider adding some kind of test coverage, if only for the setters/getters of the platforms.

Android Build needs to be fixed.

yousifd added 3 commits July 29, 2025 12:51

expose frustumoffset in the core and use it for modifying the view fr…

3be289a

…ustum

expose frustum offset flag to android and enable scissor test for ope…

5abaaee

…ngl and vulkan

expose frustum offset on ios and enable scissor test for metal

cf8bfc7

yousifd mentioned this pull request Jul 29, 2025

Ability to set draw area to avoid rendering tiles behind UI elements at the edges of the screen #3677

Open

adrian-cojocaru approved these changes Jul 30, 2025

View reviewed changes

remove viewextent from vulkan pipeline hash and frustum offset from m…

87176e9

…ap options

yousifd force-pushed the frustum_offset_maplibre branch from 1cbe8db to 87176e9 Compare July 31, 2025 09:34

louwers added the ⚡ performance label Jul 31, 2025

louwers mentioned this pull request Jul 31, 2025

Call for Submissions: July 2025 Newsletter maplibre/maplibre.github.io#431

Closed

louwers reviewed Aug 6, 2025

View reviewed changes

src/mbgl/gfx/scissor_rect.hpp

class ScissorRect {

public:

int32_t x, y;

Copy link

Member

louwers Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put these on their own lines.

louwers reviewed Aug 6, 2025

View reviewed changes

src/mbgl/gfx/scissor_rect.hpp

class ScissorRect {

public:

int32_t x, y;

uint32_t width, height;

Copy link

Member

louwers Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put on individual lines.

louwers approved these changes Aug 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Frustum Offset Proposal #3676

Frustum Offset Proposal #3676

Uh oh!

yousifd commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Uh oh!

adrian-cojocaru Jul 29, 2025

Uh oh!

louwers Jul 30, 2025

Uh oh!

adrian-cojocaru Jul 30, 2025

Uh oh!

yousifd Jul 31, 2025

Uh oh!

louwers Aug 6, 2025

Uh oh!

louwers Aug 6, 2025 •

edited

Loading

Uh oh!

louwers Aug 6, 2025

Uh oh!

louwers Aug 6, 2025

Uh oh!

louwers Aug 6, 2025

Uh oh!

louwers left a comment

Uh oh!

Uh oh!

	Offset applied to camera frustum and scissor rectangle. The camrea frustum is modofied
	Offset applied to camera frustum and scissor rectangle. The camrea frustum is modified

Uh oh!

Frustum Offset Proposal #3676

Are you sure you want to change the base?

Frustum Offset Proposal #3676

Uh oh!

Conversation

yousifd commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Bloaty Results (iOS) 🐋

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3676-compared-to-main.txt

Uh oh!

github-actions bot commented Jul 29, 2025

Bloaty Results 🐋

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3676-compared-to-main.txt

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louwers Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louwers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

louwers Aug 6, 2025 •

edited

Loading