controller: fix setting LR options on initialization #5444
Conversation
Signed-off-by: zhangzujian <[email protected]>
dosubot
bot
added
the
size:S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the controller's initialization logic for OVN logical router options. It improves the robustness and idempotency of the option setting process by ensuring that existing options are preserved and that updates to the OVN Northbound database only occur when actual changes are needed.
Highlights
- Logical Router Options Management: The pull request refactors how logical router (LR) options are set during controller initialization. Previously, a fixed set of options would unconditionally overwrite existing LR options. Now, the existing options are copied, specific required options (
mac_binding_age_threshold,dynamic_neigh_routers) are applied, and thealways_learn_from_arp_request: falseoption is no longer hardcoded during this initialization step. - Idempotency and Efficiency: A check has been added to compare the current logical router options with the desired options. The update to the OVN Northbound database is now only performed if there is a difference, making the initialization process more idempotent and preventing unnecessary API calls.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the initialization of logical router options to avoid overwriting existing settings. The new approach preserves existing options and only ensures specific ones are set, which is a good improvement. However, one of the previously set options, always_learn_from_arp_request, appears to have been missed in the refactoring. I've added a comment to address this potential issue.
| lrOptions["mac_binding_age_threshold"] = "300" | ||
| lrOptions["dynamic_neigh_routers"] = "true" |
There was a problem hiding this comment.
The previous implementation set the always_learn_from_arp_request option to "false", but this has been removed in the refactoring. Was this intentional?
If this option defaults to true, removing this could have security or stability implications by allowing the router to learn MAC addresses from unsolicited ARP requests. It seems this option should be preserved to maintain existing behavior.
lrOptions["always_learn_from_arp_request"] = "false"
lrOptions["mac_binding_age_threshold"] = "300"
lrOptions["dynamic_neigh_routers"] = "true"
There was a problem hiding this comment.
Why always_learn_from_arp_request is removed
There was a problem hiding this comment.
This option should not be set/changed during initialization.
Pull Request Test Coverage Report for Build 16162770073Details
💛 - Coveralls |
Signed-off-by: zhangzujian <[email protected]>
Signed-off-by: zhangzujian <[email protected]>
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)