controller: fix setting LR options on initialization (#5444)

Signed-off-by: zhangzujian <[email protected]>

Author: zhangzujian

pkg/controller/init.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"maps"
 	"strings"
 	"time"
 
@@ -238,11 +239,16 @@ func (c *Controller) initClusterRouter() error {
 		return err
 	}
 
-	lr.Options = map[string]string{"always_learn_from_arp_request": "false", "dynamic_neigh_routers": "true", "mac_binding_age_threshold": "300"}
-	err = c.OVNNbClient.UpdateLogicalRouter(lr, &lr.Options)
-	if err != nil {
-		klog.Errorf("update logical router %s failed: %v", c.config.ClusterRouter, err)
-		return err
+	lrOptions := make(map[string]string, len(lr.Options))
+	maps.Copy(lrOptions, lr.Options)
+	lrOptions["mac_binding_age_threshold"] = "300"
+	lrOptions["dynamic_neigh_routers"] = "true"
+	if !maps.Equal(lr.Options, lrOptions) {
+		lr.Options = lrOptions
+		if err = c.OVNNbClient.UpdateLogicalRouter(lr, &lr.Options); err != nil {
+			klog.Errorf("update logical router %s failed: %v", c.config.ClusterRouter, err)
+			return err
+		}
 	}
 
 	return nil