Skip to content

fix(cypress): fix itaubank, datatrans and facilitapay #8229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 10, 2025
Merged

fix(cypress): fix itaubank, datatrans and facilitapay #8229

merged 9 commits into from
Jun 10, 2025
+594 −8

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jun 3, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes Cypress tests for Itaubank, Paybox and Datatrans.

Datatrans still fail. Datatrans fails because ResponseCustom needs a refactor while Paybox requires us to pass FR as country and upon fixing it, it started to say wrong creds.

Facilitapay has no issues. Wise and Elavon creds issue.

JP Morgan addressed in #8282

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fix stuff. Closes #8230

How did you test it?

command screenshot
CYPRESS_CONNECTOR=itaubank npm run cypress:payments image
CYPRESS_CONNECTOR=datatrans npm run cypress:payments image
CYPRESS_CONNECTOR=facilitapay npm run cypress:payments image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate requested a review from a team as a code owner June 3, 2025 12:45
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jun 3, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/e2e/configs/Payment/ItauBank.js  5% smaller
  cypress-tests/cypress/e2e/configs/Payment/Datatrans.js  1% smaller
  cypress-tests/cypress/e2e/configs/Payment/Modifiers.js  0% smaller
  cypress-tests/cypress/e2e/configs/Payment/Utils.js  0% smaller

@pixincreate pixincreate self-assigned this Jun 3, 2025
@Gnanasundari24
Copy link
Contributor

@pixincreate Add entire testcases screenshot for paybox and other connectors

@pixincreate
Merge branches 'cypress/fix' and 'main' of github.com:juspay/hyperswi…
8f846e0 
…tch into cypress/fix

* 'cypress/fix' of github.com:juspay/hyperswitch:
  chore(cypress): run formatter and address lints

* 'main' of github.com:juspay/hyperswitch:
  feat(router): add merchantId authentication for Payments v2 (#8239)
  chore(version): 2025.06.06.0
  Documentation edits made through Mintlify web editor
  Documentation edits made through Mintlify web editor
  feat(router): Return payment_experience in PML for payment (v2) (#8255)
  refactor: add infra-values in intent kafka events (#8264)
  fix(wasm): [Worldpayvantiv] add support for metadata.report_group (#8260)
  chore(version): 2025.06.05.0
  revert(routing): Add connectors from current active routing algorithm before adding fallback connectors (#8207)
  feat(connectors): [Worldpayvantiv] add card support (#8219)
  feat(connectors): [Template] add Worldpayvantiv  (#8226)
  refactor(dynamic_routing): add logic for creating merchant account in decision engine (#8191)
  feat(events): adding infra level components to api-events (#8214)
  chore(version): 2025.06.04.0
  feat(core): add support for consuming eci for AuthNResponse in Authentication flow (#8225)
@pixincreate pixincreate changed the title fix(cypress): fix itaubank, paybox, datatrans fix(cypress): fix itaubank, jpmorgan, datatrans Jun 8, 2025
@pixincreate pixincreate changed the title fix(cypress): fix itaubank, jpmorgan, datatrans fix(cypress): fix itaubank, datatrans Jun 8, 2025
@pixincreate pixincreate changed the title fix(cypress): fix itaubank, datatrans fix(cypress): fix itaubank, datatrans and facilitapay Jun 9, 2025
likhinbopanna
likhinbopanna reviewed Jun 10, 2025
View reviewed changes
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 10, 2025
@pixincreate pixincreate added this to the June 2025 Release milestone Jun 10, 2025
@likhinbopanna likhinbopanna enabled auto-merge June 10, 2025 08:24
@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit e0ea1b4 Jun 10, 2025
16 of 23 checks passed
@likhinbopanna likhinbopanna deleted the cypress/fix branch June 10, 2025 10:26
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 10, 2025
pixincreate added a commit that referenced this pull request Jun 10, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/n…
b1d0884 
…ordea-sepa

* 'main' of github.com:juspay/hyperswitch: (63 commits)
  feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096)
  fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309)
  refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286)
  fix: payment link styling for dynamic classes (#8273)
  feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201)
  fix(cypress): fix itaubank, datatrans and facilitapay (#8229)
  fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282)
  revert(connector): [Worldpay] add root CA certificate (#8224)
  ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209)
  fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183)
  chore(version): 2025.06.10.0
  feat(tokenio): Add OpenBanking Redirection Flow (#8152)
  fix: Unified scarf setup (#8238)
  feat(health): Health check for Decision engine (#8243)
  chore: Update apple pay currency filter configs (#8217)
  refactor(customers_v2): Remove merchant reference id from v2 customer update (#7879)
  chore(version): 2025.06.09.0
  chore(postman): update Postman collection files
  ci(postman): add tunnel collection to postman tests (#8269)
  feat(connector): Added recurring payments support for split payments in Stripe (#8271)
  ...
pixincreate added a commit that referenced this pull request Jun 10, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/n…
93b320a 
…ordea-sepa

* 'main' of github.com:juspay/hyperswitch: (63 commits)
  feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096)
  fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309)
  refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286)
  fix: payment link styling for dynamic classes (#8273)
  feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201)
  fix(cypress): fix itaubank, datatrans and facilitapay (#8229)
  fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282)
  revert(connector): [Worldpay] add root CA certificate (#8224)
  ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209)
  fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183)
  chore(version): 2025.06.10.0
  feat(tokenio): Add OpenBanking Redirection Flow (#8152)
  fix: Unified scarf setup (#8238)
  feat(health): Health check for Decision engine (#8243)
  chore: Update apple pay currency filter configs (#8217)
  refactor(customers_v2): Remove merchant reference id from v2 customer update (#7879)
  chore(version): 2025.06.09.0
  chore(postman): update Postman collection files
  ci(postman): add tunnel collection to postman tests (#8269)
  feat(connector): Added recurring payments support for split payments in Stripe (#8271)
  ...
pixincreate added a commit that referenced this pull request Jun 10, 2025
@pixincreate
Merge branch 'trustpay-banktransfer' of github.com:juspay/hyperswitch…
2a1e75a 
… into trustpay-banktransfer

* 'trustpay-banktransfer' of github.com:juspay/hyperswitch:
  feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096)
  fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309)
  refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286)
  fix: payment link styling for dynamic classes (#8273)
  feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201)
  fix(cypress): fix itaubank, datatrans and facilitapay (#8229)
  fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282)
  revert(connector): [Worldpay] add root CA certificate (#8224)
  ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209)
  fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183)
  chore(version): 2025.06.10.0
bsayak03 pushed a commit that referenced this pull request Jun 11, 2025
@pixincreate @hyperswitch-bot
fix(cypress): fix itaubank, datatrans and facilitapay (#8229)
fcf36e4 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@likhinbopanna likhinbopanna likhinbopanna approved these changes

Assignees

@pixincreate pixincreate

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
June 2025 Release
Development

Successfully merging this pull request may close these issues.

[CYPRESS] Fix Cypress connector failures
3 participants
@pixincreate @Gnanasundari24 @likhinbopanna