ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector #8209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
likhinbopanna
changed the title
likhinbopanna
changed the title
Gnanasundari24
previously approved these changes
Jun 9, 2025
pixincreate
reviewed
Jun 9, 2025
Comment on lines
+382
to
+401
| MandateSingleUseNo3DSManualCapture: { | ||
| Configs: { | ||
| TRIGGER_SKIP: true, | ||
| }, | ||
| Request: { | ||
| payment_method: "card", | ||
| payment_method_data: { | ||
| card: successfulNo3DSCardDetails, | ||
| }, | ||
| currency: "EUR", | ||
| mandate_data: singleUseMandateData, | ||
| billing: billingAddress, | ||
| }, | ||
| Response: { | ||
| status: 200, | ||
| body: { | ||
| status: "requires_capture", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
since the setup_future_usage does a fallback to on_session when mandate is not supported, we can start moving this config to Commons (refactor commons) such that, instead of expecting the 501 we expect a 2xx response which can be overriden by connectors if they expect a different status in the response with TRIGGER_SKIP set to true just because mandate payments shouldn't happen.
yes, this can be considered in a separate pr given the complexity and the work involved.
There was a problem hiding this comment.
i would want this to be kept unresolved for now. if not asking for much, can you please open an issue on this topic so that it can be picked in future and not left as a tech debt?
Gnanasundari24
approved these changes
Jun 10, 2025
pixincreate
approved these changes
Jun 10, 2025
pixincreate
added a commit
that referenced
this pull request
Jun 10, 2025
…ordea-sepa * 'main' of github.com:juspay/hyperswitch: (63 commits) feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096) fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309) refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286) fix: payment link styling for dynamic classes (#8273) feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201) fix(cypress): fix itaubank, datatrans and facilitapay (#8229) fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282) revert(connector): [Worldpay] add root CA certificate (#8224) ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209) fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183) chore(version): 2025.06.10.0 feat(tokenio): Add OpenBanking Redirection Flow (#8152) fix: Unified scarf setup (#8238) feat(health): Health check for Decision engine (#8243) chore: Update apple pay currency filter configs (#8217) refactor(customers_v2): Remove merchant reference id from v2 customer update (#7879) chore(version): 2025.06.09.0 chore(postman): update Postman collection files ci(postman): add tunnel collection to postman tests (#8269) feat(connector): Added recurring payments support for split payments in Stripe (#8271) ...
pixincreate
added a commit
that referenced
this pull request
Jun 10, 2025
…ordea-sepa * 'main' of github.com:juspay/hyperswitch: (63 commits) feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096) fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309) refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286) fix: payment link styling for dynamic classes (#8273) feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201) fix(cypress): fix itaubank, datatrans and facilitapay (#8229) fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282) revert(connector): [Worldpay] add root CA certificate (#8224) ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209) fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183) chore(version): 2025.06.10.0 feat(tokenio): Add OpenBanking Redirection Flow (#8152) fix: Unified scarf setup (#8238) feat(health): Health check for Decision engine (#8243) chore: Update apple pay currency filter configs (#8217) refactor(customers_v2): Remove merchant reference id from v2 customer update (#7879) chore(version): 2025.06.09.0 chore(postman): update Postman collection files ci(postman): add tunnel collection to postman tests (#8269) feat(connector): Added recurring payments support for split payments in Stripe (#8271) ...
pixincreate
added a commit
that referenced
this pull request
Jun 10, 2025
… into trustpay-banktransfer * 'trustpay-banktransfer' of github.com:juspay/hyperswitch: feat(connector): [TRUSTPAY] Added Integrity Checks for PSync & RSync flows & Added New Variants in AttemptStatus & IntentStatus (#8096) fix(connector): [STRIPE] Throwing Missing Required Field Error if connector_customer is not present (#8309) refactor(connectors): [worldpayvantiv] replace sandbox url with pre-live url and fix typo (#8286) fix: payment link styling for dynamic classes (#8273) feat(core): Make installment_payment_enabled,recurring_enabled Optional (#8201) fix(cypress): fix itaubank, datatrans and facilitapay (#8229) fix(connector): [jpmorgan] 5xx during payment authorize and `cancellation_reason` (#8282) revert(connector): [Worldpay] add root CA certificate (#8224) ci(cypress): fix fiuu, fiservemea , paybox and worldpay connector (#8209) fix(connector): removed forked josekit dependency from payout connector Nomupay (#8183) chore(version): 2025.06.10.0
bsayak03
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix fiuu, ferservmea ,paybox and worldpay connector in cypress tests
Handled 3DS test cases for connectors that do not support 3DS.
Additional Changes
Motivation and Context
How did you test it?
Issue : 1. After creating 3ds payment but without complete the redirection , When psync is done , throwing this error
Issue : 1. Zero auth mandate goes to processing state and test cases are failing
2. Merchant Payment method list is
nullIssue : 1. zero auth mandate goes to processing state and test cases are failing
Checklist
cargo +nightly fmt --allcargo clippy