feat(connector): Added ThreeDs server integration template pr #7424

sahkal · 2025-03-04T11:40:33Z

Type of Change

New feature

Description

Added ThreeDs server integration template pr

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-03-04T11:40:36Z

Review changes with

Changed Files

File	Status
crates/router/src/connector.rs	95% smaller
crates/hyperswitch_connectors/src/connectors.rs	80% smaller
crates/common_enums/src/enums.rs	62% smaller
crates/common_enums/src/connector_enums.rs	18% smaller
config/config.example.toml	Unsupported file format
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/connector_configs/src/connector.rs	0% smaller
crates/connector_configs/toml/development.toml	Unsupported file format
crates/connector_configs/toml/sandbox.toml	Unsupported file format
crates/hyperswitch_connectors/src/connectors/juspaythreedsserver.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/juspaythreedsserver/transformers.rs	0% smaller
crates/hyperswitch_connectors/src/default_implementations.rs	0% smaller
crates/hyperswitch_connectors/src/default_implementations_v2.rs	0% smaller
crates/hyperswitch_interfaces/src/configs.rs	0% smaller
crates/router/src/core/admin.rs	0% smaller
crates/router/src/core/payments/connector_integration_v2_impls.rs	0% smaller
crates/router/src/core/payments/flows.rs	0% smaller
crates/router/src/types/api.rs	0% smaller
crates/router/src/types/api/authentication.rs	0% smaller
crates/router/src/types/transformers.rs	0% smaller
crates/router/tests/connectors/juspaythreedsserver.rs	0% smaller
crates/router/tests/connectors/main.rs	0% smaller
crates/test_utils/src/connector_auth.rs	0% smaller
loadtest/config/development.toml	Unsupported file format
scripts/add_connector.sh	Unsupported file format

NishantJoshi00

LGTM, the comments can be addressed later on as well.

NishantJoshi00 · 2025-03-05T07:07:22Z

config/docker_compose.toml

@@ -155,6 +155,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
 inespay.base_url = "https://apiflow.inespay.com/san/v21"
 itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
 jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
+juspaythreedsserver.base_url = "http://localhost:8000"
 jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"


Suggested change

jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"

jpmorgan.secondary_base_url = "https://id.payments.jpmorgan.com"

nit: consistant formatting

NishantJoshi00 · 2025-03-05T07:08:40Z

crates/connector_configs/src/connector.rs

@@ -156,6 +156,7 @@ pub struct ConnectorTomlConfig {
 #[serde_with::skip_serializing_none]
 #[derive(Debug, Deserialize, serde::Serialize, Clone)]
 pub struct ConnectorConfig {
+    pub juspaythreedsserver: Option<ConnectorTomlConfig>,


can you put it in the ascending order of the names? Also, is this a single word or is it? juspay_threeds_server?

ascending order fix i will take this while completing the integration with transformers and types

* 'main' of github.com:juspay/hyperswitch: feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427)

…juspay/hyperswitch into connector/gpay-mandates-authorizedotnet * 'connector/gpay-mandates-authorizedotnet' of github.com:juspay/hyperswitch: (25 commits) ci(cypress): address lints and refactor redirection handler (#7437) chore: make v1 merchant account forward compatible (#7426) fix(dashboard): Added auth key to juspay threeds server (#7457) feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427) feat(connector): [EFT] Add EFT as a payment method (#7304) chore(version): 2025.03.05.1 feat(connector): [Moneris] Implement mandate for Moneris (#7322) ...

added juspay threeds server integration template pr

304c8d1

sahkal added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 4, 2025

sahkal added this to the February 2025 Release milestone Mar 4, 2025

sahkal self-assigned this Mar 4, 2025

sahkal requested review from a team as code owners March 4, 2025 11:40

swangi-kumari previously approved these changes Mar 4, 2025

View reviewed changes

sai-harsha-vardhan previously approved these changes Mar 4, 2025

View reviewed changes

ShankarSinghC previously approved these changes Mar 5, 2025

View reviewed changes

NishantJoshi00 previously approved these changes Mar 5, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Mar 5, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 5, 2025

added juspay 3ds as authentication connector

af2fa4f

sahkal dismissed stale reviews from NishantJoshi00, ShankarSinghC, sai-harsha-vardhan, and swangi-kumari via af2fa4f March 6, 2025 07:43

swangi-kumari previously approved these changes Mar 6, 2025

View reviewed changes

sai-harsha-vardhan previously approved these changes Mar 6, 2025

View reviewed changes

Merge branch 'main' into 8671-integration-inrtegrate-juspay-3ds-server

8509c07

ShankarSinghC previously approved these changes Mar 6, 2025

View reviewed changes

fixed clippy errors

df3ecd7

sahkal dismissed stale reviews from ShankarSinghC, sai-harsha-vardhan, and swangi-kumari via df3ecd7 March 6, 2025 08:14

deepanshu-iiitu approved these changes Mar 6, 2025

View reviewed changes

ShankarSinghC approved these changes Mar 6, 2025

View reviewed changes

sai-harsha-vardhan approved these changes Mar 6, 2025

View reviewed changes

sahkal requested review from likhinbopanna and Gnanasundari24 March 6, 2025 09:26

NishantJoshi00 approved these changes Mar 6, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Mar 6, 2025

Merged via the queue into main with commit 7e5da48 Mar 6, 2025
14 of 20 checks passed

likhinbopanna deleted the 8671-integration-inrtegrate-juspay-3ds-server branch March 6, 2025 10:48

This was referenced Mar 6, 2025

refactor(core): Added payment id in authentication router data #7444

Closed

feat(connector): Added ThreeDs server integration template pr #7446

Merged

hyperswitch-bot bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(connector): Added ThreeDs server integration template pr #7424

feat(connector): Added ThreeDs server integration template pr #7424

Uh oh!

sahkal commented Mar 4, 2025

Uh oh!

semanticdiff-com bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

NishantJoshi00 left a comment

Uh oh!

NishantJoshi00 Mar 5, 2025

Uh oh!

NishantJoshi00 Mar 5, 2025

Uh oh!

sahkal Mar 5, 2025

Uh oh!

Uh oh!

Uh oh!

	jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"
	jpmorgan.secondary_base_url = "https://id.payments.jpmorgan.com"

feat(connector): Added ThreeDs server integration template pr #7424

feat(connector): Added ThreeDs server integration template pr #7424

Uh oh!

Conversation

sahkal commented Mar 4, 2025

Type of Change

Description

Checklist

Uh oh!

semanticdiff-com bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NishantJoshi00 left a comment

Choose a reason for hiding this comment

Uh oh!

NishantJoshi00 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

NishantJoshi00 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

sahkal Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

semanticdiff-com bot commented Mar 4, 2025 •

edited

Loading