feat(core): add additional revenue recovery call flow #7402

NISHANTH1221 · 2025-03-03T08:33:24Z

Type of Change

Description

For some billing connectors, we get limited data in the webhook that is not sufficient to use. So we need to make an additional api call for this extra data. This pr adds that flow.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

No testing required since its just defining the flow not using it.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-03-03T08:33:27Z

Review changes with

Changed Files

File	Status
crates/router/src/types.rs	85% smaller
crates/router/src/types/api.rs	49% smaller
crates/hyperswitch_interfaces/src/types.rs	34% smaller
crates/hyperswitch_domain_models/src/types.rs	33% smaller
crates/hyperswitch_connectors/src/default_implementations.rs	9% smaller
crates/router/src/core/payments/flows.rs	6% smaller
config/config.example.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/hyperswitch_domain_models/src/router_data_v2/flow_common_types.rs	0% smaller
crates/hyperswitch_domain_models/src/router_flow_types.rs	0% smaller
crates/hyperswitch_domain_models/src/router_flow_types/revenue_recovery.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs	0% smaller
crates/hyperswitch_domain_models/src/router_response_types.rs	0% smaller
crates/hyperswitch_domain_models/src/router_response_types/revenue_recovery.rs	0% smaller
crates/hyperswitch_interfaces/src/api.rs	0% smaller
crates/hyperswitch_interfaces/src/api/revenue_recovery.rs	0% smaller
crates/hyperswitch_interfaces/src/api/revenue_recovery_v2.rs	0% smaller
crates/router/Cargo.toml	Unsupported file format
crates/router/src/configs/secrets_transformers.rs	0% smaller
crates/router/src/configs/settings.rs	0% smaller
crates/router/src/services/api.rs	0% smaller

…all_flow

…Data

… unified authentication service connector

hrithikesh026 · 2025-03-04T11:55:34Z

crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs

@@ -0,0 +1,5 @@
+#[derive(Debug, Clone)]
+pub struct GetAdditionalRevenueRecoveryRequestData {
+    // stripe charge id for additional call


Suggested change

// stripe charge id for additional call

/// unique id for making additional revenue recovery call

crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs

srujanchikke · 2025-03-04T13:03:07Z

crates/router/src/configs/secrets_transformers.rs

@@ -506,6 +506,7 @@ pub(crate) async fn fetch_raw_secrets(
        required_fields: conf.required_fields,
        delayed_session_response: conf.delayed_session_response,
        webhook_source_verification_call: conf.webhook_source_verification_call,
+        // additional_revenue_recovery_details_call: conf.additional_revenue_recovery_details_call,


Why is this commented ?

since the connector is not enabled the cypress tests will fail on this. I will enable it in subsequent pr's

srujanchikke · 2025-03-04T13:03:46Z

crates/router/src/configs/settings.rs

@@ -96,6 +96,7 @@ pub struct Settings<S: SecretState> {
    pub required_fields: RequiredFields,
    pub delayed_session_response: DelayedSessionConfig,
    pub webhook_source_verification_call: WebhookSourceVerificationCall,
+    // pub additional_revenue_recovery_details_call: GetAdditionalRevenueRecoveryDetailsCall,


the connector is not enabled so we will get an error when we try to run the file because we have stripebilling in config and we don't have corresponding enabled connector

* 'main' of github.com:juspay/hyperswitch: feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427)

…juspay/hyperswitch into connector/gpay-mandates-authorizedotnet * 'connector/gpay-mandates-authorizedotnet' of github.com:juspay/hyperswitch: (25 commits) ci(cypress): address lints and refactor redirection handler (#7437) chore: make v1 merchant account forward compatible (#7426) fix(dashboard): Added auth key to juspay threeds server (#7457) feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427) feat(connector): [EFT] Add EFT as a payment method (#7304) chore(version): 2025.03.05.1 feat(connector): [Moneris] Implement mandate for Moneris (#7322) ...

Nishanth Challa and others added 13 commits February 9, 2025 12:36

add template code for stripebilling

a0ffaa7

add logic instead of todo in template code

bb432a5

chore: run formatter

4555023

Merge branch 'main' into template_code_stripebilling

8ab0630

fixes errors

2ad25d7

chore: run formatter

3c38093

Merge branch 'main' into template_code_stripebilling

a2ca88b

resolved error in default implementation

4412b10

additional api call flow for revenue recovery

d6c7f7a

Merge branch 'main' into template_code_stripebilling

0139e03

chore: run formatter

ccfcff3

Merge branch 'main' into template_code_stripebilling

4abdce9

Merge branch 'main' into template_code_stripebilling

6e08413

NISHANTH1221 self-assigned this Mar 3, 2025

NISHANTH1221 requested review from a team as code owners March 3, 2025 08:33

hyperswitch-bot bot and others added 5 commits March 3, 2025 08:56

chore: run formatter

3295979

changes in name of the flow in config files

0d5a8ea

chore: run formatter

1ad2464

Merge branch 'template_code_stripebilling' into additional_recovery_c…

70b7546

…all_flow

add paystack in deafult implememtation additional call flow

966ce1b

Base automatically changed from template_code_stripebilling to main March 3, 2025 10:35

NISHANTH1221 requested a review from a team as a code owner March 3, 2025 10:35

Merge branch 'main' into additional_recovery_call_flow

6f4573a

NISHANTH1221 changed the title ~~feat(core) : add additional revenue recovery call flow~~ feat(core): add additional revenue recovery call flow Mar 3, 2025

Nishanth Challa and others added 3 commits March 3, 2025 17:27

added paystack connector in default implementation

4a34e07

add debug and clone trait to Additional Revenue Recovery Flow Common …

e10b589

…Data

chore: run formatter

145a6d9

hyperswitch-bot bot and others added 7 commits March 4, 2025 06:33

chore: run formatter

524cce1

refactor: reorganize revenue recovery module structure

66132cb

chore: run formatter

fc01f6c

Merge branch 'main' into additional_recovery_call_flow

f93bbc6

change v2 to v1

51e6dcd

refactor: update additional revenue recovery call implementations for…

e5b8314

… unified authentication service connector

refactor: add RevenueRecovery trait and update related implementations

25855cc

hrithikesh026 reviewed Mar 4, 2025

View reviewed changes

crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs Outdated Show resolved Hide resolved

hyperswitch-bot bot and others added 2 commits March 4, 2025 12:10

chore: run formatter

ad1e7dd

refactor: update revenue recovery request data structure

7c05cb5

srujanchikke reviewed Mar 4, 2025

View reviewed changes

srujanchikke previously approved these changes Mar 4, 2025

View reviewed changes

NISHANTH1221 removed the request for review from a team March 5, 2025 07:56

NISHANTH1221 and others added 2 commits March 5, 2025 16:17

Merge branch 'main' into additional_recovery_call_flow

f09f19c

feat(connector): add Recurly to additional revenue recovery call

5bf5bf1

NISHANTH1221 dismissed srujanchikke’s stale review via 5bf5bf1 March 5, 2025 11:50

srujanchikke approved these changes Mar 5, 2025

View reviewed changes

ShankarSinghC approved these changes Mar 5, 2025

View reviewed changes

NISHANTH1221 removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 5, 2025

likhinbopanna added this pull request to the merge queue Mar 5, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025

Merge branch 'main' into additional_recovery_call_flow

15952db

likhinbopanna added this pull request to the merge queue Mar 6, 2025

Merged via the queue into main with commit 9e4135c Mar 6, 2025
14 of 20 checks passed

likhinbopanna deleted the additional_recovery_call_flow branch March 6, 2025 07:14

NISHANTH1221 mentioned this pull request Mar 27, 2025

feat(connector): Add recovery support for stripebilling #7461

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(core): add additional revenue recovery call flow #7402

feat(core): add additional revenue recovery call flow #7402

Uh oh!

NISHANTH1221 commented Mar 3, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Mar 3, 2025 •

edited

Loading

Uh oh!

hrithikesh026 Mar 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

srujanchikke Mar 4, 2025

Uh oh!

NISHANTH1221 Mar 4, 2025

Uh oh!

srujanchikke Mar 4, 2025

Uh oh!

NISHANTH1221 Mar 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	// stripe charge id for additional call
	/// unique id for making additional revenue recovery call

feat(core): add additional revenue recovery call flow #7402

feat(core): add additional revenue recovery call flow #7402

Uh oh!

Conversation

NISHANTH1221 commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

Checklist

Uh oh!

semanticdiff-com bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hrithikesh026 Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srujanchikke Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

NISHANTH1221 Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

srujanchikke Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

NISHANTH1221 Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NISHANTH1221 commented Mar 3, 2025 •

edited

Loading

semanticdiff-com bot commented Mar 3, 2025 •

edited

Loading

hrithikesh026 Mar 4, 2025 •

edited

Loading