Skip to content

Conversation

ArjunKarthik
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

We need to populate the merchant_defined_information for each payment with data coming from merchant in payment requests metadata.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing can be done by creating a card/gpay/applepay payment and by passing the following metadata in PAYMENTS-CREATE:
"metadata": { "count_tickets": 1, "transaction_number": "5590043" }

You should then be able to see the metadata on BOA dashboard for that payment:
Screenshot 2023-12-26 at 8 34 14 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik requested review from a team as code owners January 5, 2024 06:56
@ArjunKarthik ArjunKarthik changed the base branch from main to hotfix-1.105.0 January 5, 2024 06:56
@ArjunKarthik ArjunKarthik self-assigned this Jan 5, 2024
@ArjunKarthik ArjunKarthik added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-connector-integration Area: Connector integration A-connector-compatibility Area: Connector compatibility and removed A-connector-integration Area: Connector integration labels Jan 5, 2024
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-picked commit from main for hotfix so LGTM

@bernard-eugine bernard-eugine merged commit ec08236 into hotfix-1.105.0 Jan 5, 2024
@bernard-eugine bernard-eugine deleted the meta_data_hf branch January 5, 2024 09:54
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants