feat(connector): [BOA] Populate merchant_defined_information with metadata #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-connector-integration
ArjunKarthik
suggested changes
Dec 27, 2023
| #[derive(Debug, Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct MerchantDefinedInformation { | ||
| key: u64, |
There was a problem hiding this comment.
The function vector.length() return length as u64 and that is why I have mapped it this way. Should I change it?
There was a problem hiding this comment.
Why do you need vector.length(), you can declare a u8 variable initialize it to 1 and increment it while iterating through loop
| fn foreign_from(metadata: Value) -> Self { | ||
| let m: HashMap<String, Value> = | ||
| serde_json::from_str(&metadata.to_string()).unwrap_or(HashMap::new()); | ||
| let mut v: Self = Self::new(); |
There was a problem hiding this comment.
please use proper naming for the variable
| let size = v.length() + 1; | ||
| v.push(MerchantDefinedInformation { | ||
| key: size, | ||
| value: format!("{key} = {value}"), |
There was a problem hiding this comment.
Please use delimiter without space.
ArjunKarthik
approved these changes
Dec 27, 2023
ThisIsMani
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We need to populate the merchant_defined_information for each payment with data coming from merchant in payment requests metadata.
VAS PR: https://github.com/juspay/hyperswitch-cloud/pull/3715
Additional Changes
Motivation and Context
https://github.com/juspay/hyperswitch-cloud/issues/3713
How did you test it?
Testing can be done by creating a card/gpay/applepay payment and by passing the following metadata in PAYMENTS-CREATE:
"metadata": { "count_tickets": 1, "transaction_number": "5590043" }You should then be able to see the metadata on BOA dashboard for that payment:
Checklist
cargo +nightly fmt --allcargo clippy