feat(r/flexible_board): allow panel positions to be autogenerated #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
from
f4e3522 to
8c7044f
Compare
roncodingenthusiast
changed the title
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
2 times, most recently
from
44900ce to
83f0874
Compare
jharley
requested changes
Jul 14, 2025
| @@ -0,0 +1,103 @@ | |||
| package validation | |||
There was a problem hiding this comment.
FWIW: I've learned that resource-specific ValidiateConfig methods are a bit nicer to reason about, but there is already some "one resource only" examples of validators here in the project.
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
from
cc01b33 to
6f7405d
Compare
elimt
reviewed
Jul 17, 2025
jharley
reviewed
Jul 18, 2025
| @@ -289,6 +302,301 @@ func (r *flexibleBoardResource) ImportState(ctx context.Context, req resource.Im | |||
| resource.ImportStatePassthroughID(ctx, path.Root("id"), req, resp) | |||
| } | |||
|
|
|||
| func (*flexibleBoardResource) UpgradeState(ctx context.Context) map[int64]resource.StateUpgrader { | |||
| // upgrade state as position is not an object and | |||
There was a problem hiding this comment.
great job on this! A first in our codebase ✨
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
from
3bb45f1 to
24ec006
Compare
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
from
24ec006 to
10143be
Compare
jharley
approved these changes
Jul 21, 2025
| ), | ||
| }, | ||
| // now add an SLO panel, remove chart settings from the query panel, remove tags | ||
| // now add an SLO panel, remove chart settings from the query panel, remove tags and update from generated positions to provided positions |
There was a problem hiding this comment.
as discussed: there is a non-blocking bug here where switching panels from provided positions to unprovided positions isn't detected (manual -> auto). This can be fixed in followup as a bugfix.
roncodingenthusiast
force-pushed
the
ronald/fix-tf-auto-grid
branch
from
10143be to
2438ddb
Compare
roncodingenthusiast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
How to verify that this has the expected result
fixes #692