Clean up comments and restore validators

Author: tanya-coding

internal/provider/flexible_board_resource.go

@@ -119,38 +119,36 @@ func (*flexibleBoardResource) Schema(_ context.Context, _ resource.SchemaRequest
 									Computed:    true,
 									Required:    false,
 									Description: "The X coordinate of the panel.",
-									// Default:     int64default.StaticInt64(0),
-									// Validators: []validator.Int64{
-									// 	int64validator.AtLeast(0),
-									// },
+									Validators: []validator.Int64{
+										int64validator.AtLeast(0),
+									},
 								},
 								"y_coordinate": schema.Int64Attribute{
 									Optional:    true,
 									Computed:    true,
 									Required:    false,
 									Description: "The Y coordinate of the panel.",
-									// Default:     int64default.StaticInt64(0),
-									// Validators: []validator.Int64{
-									// 	int64validator.AtLeast(0),
-									// },
+									Validators: []validator.Int64{
+										int64validator.AtLeast(0),
+									},
 								},
 								"height": schema.Int64Attribute{
 									Optional:    true,
 									Computed:    true,
 									Required:    false,
 									Description: "The height of the panel.",
-									// Validators: []validator.Int64{
-									// 	int64validator.AtLeast(1),
-									// },
+									Validators: []validator.Int64{
+										int64validator.AtLeast(1),
+									},
 								},
 								"width": schema.Int64Attribute{
 									Optional:    true,
 									Computed:    true,
 									Required:    false,
 									Description: "The width of the panel.",
-									// Validators: []validator.Int64{
-									// 	int64validator.AtLeast(1),
-									// },
+									Validators: []validator.Int64{
+										int64validator.AtLeast(1),
+									},
 								},
 							},
 						},
@@ -589,14 +587,6 @@ func expandPanelPosition(
 
 	var position models.BoardPanelPositionModel
 	diags.Append(panelPosition.As(ctx, &position, basetypes.ObjectAsOptions{})...)
-	// diags.Append(panelPosition.ElementsAs(ctx, &position, false)...)
-
-	// if len(position) == 0 {
-	// 	return client.BoardPanelPosition{
-	// 		X: -1,
-	// 		Y: -1,
-	// 	}
-	// }
 
 	return client.BoardPanelPosition{
 		X:      int(position.XCoordinate.ValueInt64()),
@@ -751,13 +741,6 @@ func flattenBoardPanelPosition(
 	obj, d := types.ObjectValue(models.BoardPanelPositionModelAttrType, attrs)
 	diags.Append(d...)
 
-	// result, d := types.ListValueFrom(
-	// 	ctx,
-	// 	types.ObjectType{AttrTypes: models.BoardPanelPositionModelAttrType},
-	// 	[]attr.Value{obj},
-	// )
-	// diags.Append(d...)
-
 	return obj
 }
 

internal/provider/flexible_board_resource_test.go

@@ -51,7 +51,6 @@ func TestAccHoneycombioFlexibleBoard(t *testing.T) {
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.query_panel.#", "0"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.slo_panel.#", "1"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.slo_panel.0.slo_id", slo.ID),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.position.#", "0"), // confirms that position is not set
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.type", "query"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.slo_panel.#", "0"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.query_panel.#", "1"),
@@ -203,15 +202,6 @@ resource "honeycombio_flexible_board" "test" {
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.query_panel.0.visualization_settings.#", "1"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.query_panel.0.visualization_settings.0.use_utc_xaxis", "false"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.query_panel.0.visualization_settings.0.chart.#", "0"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.0.position.#", "1"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.type", "slo"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.slo_panel.#", "1"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.slo_panel.0.slo_id", slo.ID),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.position.#", "1"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.position.x_coordinate", "0"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.position.y_coordinate", "0"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.position.height", "4"),
-					// resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "panel.1.position.width", "3"),
 					resource.TestCheckResourceAttr("honeycombio_flexible_board.test", "tags.%", "0"),
 				),
 			},