Skip to content

feat: add missing execute_on_delegate option for artifactory connector #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2025
Merged

feat: add missing execute_on_delegate option for artifactory connector #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9db2c7
feat: add missing execute_on_delegate option for artifactory connector
andresmanelli Aug 26, 2025
688fb4f
fix: set default to false
andresmanelli Aug 27, 2025
04898a9
chore: update harness-sdk-go
andresmanelli Aug 27, 2025
76b96db
fix: remove newline
andresmanelli Aug 27, 2025
c58a1f3
chore: bump harness-sdk-go to v0.5.14
andresmanelli Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require (
github.com/aws/aws-sdk-go v1.46.4
github.com/docker/docker v28.3.2+incompatible
github.com/google/uuid v1.6.0
github.com/harness/harness-go-sdk v0.5.13
github.com/harness/harness-go-sdk v0.5.14
github.com/harness/harness-openapi-go-client v0.0.25
github.com/hashicorp/go-cleanhttp v0.5.2
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
Expand Down
6 changes: 4 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1 h1:e9Rjr40Z98/clHv5Yg79Is0NtosR5LXRvdr7o/6NwbA=
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1/go.mod h1:tIxuGz/9mpox++sgp9fJjHO0+q1X9/UOWd798aAm22M=
github.com/harness/harness-go-sdk v0.5.13 h1:qWd7kizYGyot8jnQHYtQyKtsxyQV/npnvyW1uPrWcO4=
github.com/harness/harness-go-sdk v0.5.13/go.mod h1:CPXydorp4zd5Dz2u2FXiHyWL4yd5PQafOMN69cgPSvk=
github.com/harness/harness-go-sdk v0.5.14-0.20250827041321-2379890985fd h1:K/6dgrvNCaP0/24NvVedBUL3VDcnkSMurtXxMAyvZ8M=
github.com/harness/harness-go-sdk v0.5.14-0.20250827041321-2379890985fd/go.mod h1:CPXydorp4zd5Dz2u2FXiHyWL4yd5PQafOMN69cgPSvk=
github.com/harness/harness-go-sdk v0.5.14 h1:D2ynt6DTD6GYWZQ29QhULB7SUHskHCS45H/WXwqBKco=
github.com/harness/harness-go-sdk v0.5.14/go.mod h1:CPXydorp4zd5Dz2u2FXiHyWL4yd5PQafOMN69cgPSvk=
github.com/harness/harness-openapi-go-client v0.0.25 h1:s1ALpC6cCJCMBkEVPjAjyHTPEpBfPyV78TeXpp3CEoU=
github.com/harness/harness-openapi-go-client v0.0.25/go.mod h1:u0vqYb994BJGotmEwJevF4L3BNAdU9i8ui2d22gmLPA=
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
Expand Down
11 changes: 11 additions & 0 deletions internal/service/cd_nextgen/connector/artifactRepositories/artifactory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ func ResourceConnectorArtifactory() *schema.Resource {
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
"execute_on_delegate": {
Description: "Execute on delegate or not.",
Type: schema.TypeBool,
Optional: true,
Default: false,
},
"credentials": {
Description: "Credentials to use for authentication.",
Type: schema.TypeList,
Expand Down Expand Up @@ -136,12 +142,17 @@ func buildConnectorArtifactory(d *schema.ResourceData) *nextgen.ConnectorInfo {
}
}

if attr, ok := d.GetOk("execute_on_delegate"); ok {
connector.Artifactory.ExecuteOnDelegate = attr.(bool)
}

return connector
}

func readConnectorArtifactory(d *schema.ResourceData, connector *nextgen.ConnectorInfo) error {
d.Set("url", connector.Artifactory.ArtifactoryServerUrl)
d.Set("delegate_selectors", connector.Artifactory.DelegateSelectors)
d.Set("execute_on_delegate", connector.Artifactory.ExecuteOnDelegate)

switch connector.Artifactory.Auth.Type_ {
case nextgen.ArtifactoryAuthTypes.UsernamePassword:
Expand Down