feat: add missing execute_on_delegate option for artifactory connector #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrés MANELLI <[email protected]>
ritek01
reviewed
Aug 27, 2025
internal/service/cd_nextgen/connector/artifactRepositories/artifactory.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrés MANELLI <[email protected]>
Signed-off-by: Andrés MANELLI <[email protected]>
|
@ritek01 I updated to the latest harness-sdk-go after the merge of harness/harness-go-sdk#684 |
Signed-off-by: Andrés MANELLI <[email protected]>
|
Hey @andresmanelli , could you use the official release version of |
Signed-off-by: Andrés MANELLI <[email protected]>
|
@ritek01 done! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the execute_on_delegate configuration option to the Artifactory connector in Terraform, addressing a missing feature where users couldn't control delegation behavior.
Key changes:
- Added
execute_on_delegateschema field with boolean type and default value offalse - Implemented parsing and setting of the
execute_on_delegateoption in build and read functions - Updated the harness-go-sdk dependency to version 0.5.14 to support the new field
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/service/cd_nextgen/connector/artifactRepositories/artifactory.go | Added execute_on_delegate schema field and implementation for build/read operations |
| go.mod | Updated harness-go-sdk dependency to v0.5.14 to support the new execute_on_delegate field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [Artifactory Connector] Add missing execute_on_delegate option
Summary:
The default value created for the connector is
trueand this is not always wanted.Details:
Parsing of the
execute_on_delegateoptions was added. I used the docker connector as reference.This PR should be merged for this to work.
Related Issues:
This is the same as #1114 but for Artifactory.
PR Check triggers
trigger buildtrigger subcategoryfieldchecktrigger gitleaks