Skip to content

FFM-3625 - Flags with pre-reqs always evaluating to off state #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2022
Merged

FFM-3625 - Flags with pre-reqs always evaluating to off state #89

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c2a4c
Add logic to evaluate prereqs for a flag, to fix a bug where MV flags…
stephenmcconkey Jun 21, 2022
17dbde7
refactor to simplify logic, remove unneeded var
stephenmcconkey Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions evaluation/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,21 +297,30 @@ func prereqsSatisfied(fc FeatureConfig, target *Target, flags map[string]Feature
}

prereqsSatisfied := true
satisfiedCount := 0

for _, pre := range fc.Prerequisites {

prereqFlag, ok := flags[pre.Feature]
if !ok {
continue
}

variation := fc.Variations.FindByIdentifier(fc.GetVariationName(target))
variationToMatch := prereqFlag.Variations.FindByIdentifier(prereqFlag.GetVariationName(target))

if variation.Value != variationToMatch.Value {
prereqsSatisfied = false
if pre.Feature == prereqFlag.Feature {
for _, x := range pre.Variations {
if x == variationToMatch.Value {
satisfiedCount++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we break outer loop and return false, instead of introducing new local var

}
}
}
}

if satisfiedCount != len(fc.Prerequisites) {
prereqsSatisfied = false
}

return prereqsSatisfied
}

Expand Down
Loading