FFM-3625 - Flags with pre-reqs always evaluating to off state #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are always returning off when there is a pre req
evaluation/feature.go
Outdated
| if pre.Feature == prereqFlag.Feature { | ||
| for _, x := range pre.Variations { | ||
| if x == variationToMatch.Value { | ||
| satisfiedCount++ |
There was a problem hiding this comment.
can we break outer loop and return false, instead of introducing new local var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A bug where MV flags with prerequisite flags are always returning an off state, I also suspect there might have been issues if there are multiple prereq flags set
FFM-3625
Why
This was impacting customers using the JS SDK which in turn uses the GO SDK to evaluate flags.
Currently - the behaviour was comparing the value of a pre requisite flag against the value of a MV flag i.e. true == blue
Now - We check the prerequisites of a flag, and the status of the prereq flag to make sure they match up
Testing
Unit tests written for scenarios for single/multiple bools, mv flags with and without targets
Manual testing to ensure the expected behaviour occurred