Skip to content

[FFM-1355]: The golang SDK was not evaluating custom rules for segmen… #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

[FFM-1355]: The golang SDK was not evaluating custom rules for segmen… #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions evaluation/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,20 @@ type Clauses []Clause
func (c Clauses) Evaluate(target *Target, segments Segments) bool {
// AND operation
for _, clause := range c {
// operator should be evaluated based on type of attribute
op, err := target.GetOperator(clause.Attribute)
if err != nil {
log.Warn(err)

// If this is a SegmentMatch clause, then we don't need to get the operator for the
// attribute, as it is handled inside the Evaluate code below.
//
// If it is any other type of clause (i.e. if its an equals, contains etc)
// then we need to get the appropriate operator depending on the type of attribute
var op types.ValueType
var err error

if clause.Op != segmentMatchOperator {
op, err = target.GetOperator(clause.Attribute)
if err != nil {
log.Warn(err)
}
}
if !clause.Evaluate(target, segments, op) {
return false
Expand Down Expand Up @@ -239,12 +249,8 @@ func (fc FeatureConfig) GetVariationName(target *Target) string {
if !ok {
log.Error("The segment in variation map is invalid")
} else {
if segment.Included != nil {
for _, t := range segment.Included {
if t == target.Identifier {
return variationMap.Variation
}
}
if segment.Evaluate(target) {
return variationMap.Variation
}
}
}
Expand Down