[FFM-1355]: The golang SDK was not evaluating custom rules for segmen… #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts added directly to the flag What: If a segment is added to the flag directly (as opposed to using the segmentMatch operator) then we call segment.Evaluate() This will check if the target is included, excluded or added via custom rules. Why: Previously we only checked in the target was included in a segment, it meant custom rules were being ignored.T
enver-bisevac
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts added directly to the flag
What:
If a segment is added to the flag directly (as opposed to using the segmentMatch operator) then we
call segment.Evaluate()
This will check if the target is included, excluded or added via custom rules.
Why:
Previously we only checked in the target was included in a segment, it meant custom rules were being ignored.T