-
Notifications
You must be signed in to change notification settings - Fork 558
tests: Move sanic under toxgen & add option to control how many releases to pick #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
30413e5
tests: Move sanic under toxgen
sentrivana a060fbf
.
sentrivana 2785101
Merge branch 'master' into ivana/toxgen/sanic
sentrivana 84bd5d1
less majors
sentrivana 6bc052a
.
sentrivana 37a0b41
Merge branch 'master' into ivana/toxgen/sanic
sentrivana a487a13
Merge branch 'master' into ivana/toxgen/sanic
sentrivana ba7126d
.
sentrivana 948fa9e
.
sentrivana acf5390
.
sentrivana f01d73e
.
sentrivana 76ff2a6
simplify
sentrivana 5457f54
fix type
sentrivana 7481799
add versions_to_test
sentrivana f8da722
.
sentrivana 26564cb
Merge branch 'master' into ivana/toxgen/sanic
sentrivana 70df254
rename
sentrivana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,101 +22,6 @@ env: | |
CACHED_BUILD_PATHS: | | ||
${{ github.workspace }}/dist-serverless | ||
jobs: | ||
test-web_2-latest: | ||
name: Web 2 (latest) | ||
timeout-minutes: 30 | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9","3.12","3.13"] | ||
# python3.6 reached EOL and is no longer being supported on | ||
# new versions of hosted runners on Github Actions | ||
# ubuntu-20.04 is the last version that supported python3.6 | ||
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877 | ||
os: [ubuntu-22.04] | ||
# Use Docker container only for Python 3.6 | ||
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }} | ||
steps: | ||
- uses: actions/[email protected] | ||
- uses: actions/setup-python@v6 | ||
if: ${{ matrix.python-version != '3.6' }} | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
allow-prereleases: true | ||
- name: Setup Test Env | ||
run: | | ||
pip install "coverage[toml]" tox | ||
- name: Erase coverage | ||
run: | | ||
coverage erase | ||
- name: Test aiohttp latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-aiohttp-latest" | ||
- name: Test asgi latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-asgi-latest" | ||
- name: Test bottle latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-bottle-latest" | ||
- name: Test falcon latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-falcon-latest" | ||
- name: Test litestar latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-litestar-latest" | ||
- name: Test pyramid latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-pyramid-latest" | ||
- name: Test quart latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-quart-latest" | ||
- name: Test sanic latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-sanic-latest" | ||
- name: Test starlite latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-starlite-latest" | ||
- name: Test tornado latest | ||
run: | | ||
set -x # print commands that are executed | ||
./scripts/runtox.sh "py${{ matrix.python-version }}-tornado-latest" | ||
- name: Generate coverage XML (Python 3.6) | ||
if: ${{ !cancelled() && matrix.python-version == '3.6' }} | ||
run: | | ||
export COVERAGE_RCFILE=.coveragerc36 | ||
coverage combine .coverage-sentry-* | ||
coverage xml --ignore-errors | ||
- name: Generate coverage XML | ||
if: ${{ !cancelled() && matrix.python-version != '3.6' }} | ||
run: | | ||
coverage combine .coverage-sentry-* | ||
coverage xml | ||
- name: Upload coverage to Codecov | ||
if: ${{ !cancelled() }} | ||
uses: codecov/[email protected] | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
files: coverage.xml | ||
# make sure no plugins alter our coverage reports | ||
plugins: noop | ||
verbose: true | ||
- name: Upload test results to Codecov | ||
if: ${{ !cancelled() }} | ||
uses: codecov/test-results-action@v1 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
files: .junitxml | ||
verbose: true | ||
test-web_2-pinned: | ||
name: Web 2 (pinned) | ||
timeout-minutes: 30 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of a heuristic, should we explicitly add a
"calver": True
field in the config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's maybe a bit too specific but maybe a key with a numerical value to define how many versions should be tested? That could then be also used for some of the smaller integrations to test less versions since now it's a bit of an overkill for some
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add smth 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, see #4767 (comment)