-
Notifications
You must be signed in to change notification settings - Fork 557
tests: Move sanic under toxgen & add option to control how many releases to pick #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4767 +/- ##
==========================================
- Coverage 84.58% 84.56% -0.02%
==========================================
Files 158 158
Lines 16521 16521
Branches 2867 2867
==========================================
- Hits 13974 13971 -3
Misses 1703 1703
- Partials 844 847 +3 |
scripts/populate_tox/populate_tox.py
Outdated
# If this is the latest major release, also check the lowest | ||
# version of this version | ||
filtered_releases.add(min_version) | ||
if len(releases_by_major) > 5: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of a heuristic, should we explicitly add a "calver": True
field in the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's maybe a bit too specific but maybe a key with a numerical value to define how many versions should be tested? That could then be also used for some of the smaller integrations to test less versions since now it's a bit of an overkill for some
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add smth 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, see #4767 (comment)
-latest
group for Web 2 as all Web 2 test suites are now governed by toxgennum_versions
as a new option to optionally slim down the number of tested versions (useful for sanic as it has a lot of "majors" due to calver)Ref #4506