Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 5, 2025

  • Move sanic under toxgen
  • This gets rid of the -latest group for Web 2 as all Web 2 test suites are now governed by toxgen
  • Add num_versions as a new option to optionally slim down the number of tested versions (useful for sanic as it has a lot of "majors" due to calver)
  • When a package had multiple majors, we used to always pick the lowest as well as the highest release in the last major -- removed the lowest now to not over-test. All majors will still be tested by default, we just won't be testing two releases in the last major.

Ref #4506

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.56%. Comparing base (7ae6866) to head (70df254).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4767      +/-   ##
==========================================
- Coverage   84.58%   84.56%   -0.02%     
==========================================
  Files         158      158              
  Lines       16521    16521              
  Branches     2867     2867              
==========================================
- Hits        13974    13971       -3     
  Misses       1703     1703              
- Partials      844      847       +3     

see 3 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 17, 2025 12:11
@sentrivana sentrivana requested a review from a team as a code owner September 17, 2025 12:11
cursor[bot]

This comment was marked as outdated.

# If this is the latest major release, also check the lowest
# version of this version
filtered_releases.add(min_version)
if len(releases_by_major) > 5:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a heuristic, should we explicitly add a "calver": True field in the config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's maybe a bit too specific but maybe a key with a numerical value to define how many versions should be tested? That could then be also used for some of the smaller integrations to test less versions since now it's a bit of an overkill for some

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add smth 👍🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, see #4767 (comment)

@sentrivana sentrivana marked this pull request as draft September 18, 2025 06:29
@sentrivana sentrivana changed the title tests: Move sanic under toxgen tests: Move sanic under toxgen & add option to control how many releases to pick Sep 18, 2025
@sentrivana sentrivana marked this pull request as ready for review September 18, 2025 08:24
@sentrivana sentrivana merged commit e110151 into master Sep 18, 2025
125 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/sanic branch September 18, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants