Use get_peer_data function

[tt]

In elixir-plug/plug@d24ba4f, the peer field got replaced with a get_peer_data function.

This makes the package require Plug 1.6.0 and uses this new function to resolve the remote port.

[mitchellhenke]

Thanks for opening this!

I'll probably hold off on merging this until after I do another release as restricting to these versions of Plug may have an impact on existing users.

[mitchellhenke]

Could you change this to ~> 1.6? I think that would be equivalent to the above?

[tt]

I thought ~> 1.6 meant ">= 1.6 and < 1.7" but that's incorrect. I'll address it.

[mitchellhenke]

All good, thanks for addressing it!

If it's helpful, https://hexdocs.pm/elixir/Version.html has an explanation of the version locking rules

[mitchellhenke]

@tt Thanks again for opening this PR! 💖 💖 💖 💖

[stevedomin]

@mitchellhenke I don't think the library should use the peer's port as the remote port. With today's architectures this is often going to be wrong. Might be best to skip it.

[mitchellhenke]

@stevedomin This is an area I'm not overly familiar with, so if you don't mind I have a few questions. Is there something that would be more correct? Or it's not feasible to do that, and the current port information isn't super valuable, and should be removed?

Any links to information on the topic would also be greatly appreciated if that exists. 🙂

[stevedomin]

@mitchellhenke sure.

If your application is behind a load-balancer/proxy the X-Forwarded-Port header will sometimes be set (AWS does this I believe). The Forwarded header can also contain port information of the nodes (but it's not guaranteed).

Despite this I still think it might be best to remove it completely. It's not going to be set often enough that it is useful and having the peer port is not super valuable.