Clarification on Plug SemVer stance

[stevedomin]

Hello,

The latest release of Plug broke the build in a couple of my projects because peer was removed on %Plug.Conn{}. (this commit)

I've never really had problems with Plug before (usually upgrading late I guess) so I just wanted to clarify if it's expected that there will be breaking changes in minor version upgrade without deprecation notice?

Thanks!

[josevalim]

This was not intended. I was under the impression that peer was not released but it seems it was. Just for curiosity, can you explain how are using peer? -- *José Valim* www.plataformatec.com.br Skype: jv.ptec Founder and Director of R&D

[stevedomin]

Ah, makes sense!

I'm not using it directly but sentry-elixir is to populate the remote port. (This only going to be correct in a handful of case though, I assume it's by design).

[josevalim]

@stevedomin hrm, right. In 99% of the cases it is going to be a proxy. Including it as the remote port is allegedly wrong. /cc @mitchellhenke

I will do a new release bringing the peer back though but it will be deprecated.

[mitchellhenke]

@josevalim @stevedomin thanks for the heads up!

Have already received a PR to fix this (getsentry/sentry-elixir#273)

[josevalim]

Fixed in 1.6.2.

[stevedomin]

Thanks @josevalim!