Skip to content

Conversation

mitchellhenke
Copy link
Contributor

Related to #237

The Elixir GenEvent Behaviour had default implementations of these functions: https://github.com/elixir-lang/elixir/blob/v1.5.2/lib/elixir/lib/gen_event.ex#L117-L129

and erlang gives some warnings now because of that:

warning: undefined behaviour function code_change/3 (for behaviour :gen_event)
  lib/sentry/logger.ex:1

warning: undefined behaviour function handle_info/2 (for behaviour :gen_event)
  lib/sentry/logger.ex:1

warning: undefined behaviour function terminate/2 (for behaviour :gen_event)
  lib/sentry/logger.ex:1

So I defined them

@mitchellhenke mitchellhenke merged commit 7a458a8 into master Dec 7, 2017
@mitchellhenke mitchellhenke deleted the add-gen-event-behaviour-functions branch December 7, 2017 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant