Skip to content

fix warning for GenEvent #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2017
Merged

fix warning for GenEvent #237

merged 1 commit into from
Nov 29, 2017

Conversation

redink
Copy link
Contributor

@redink redink commented Nov 27, 2017

GenEvent module is deprecated.

If you have to implement an event handler to integrate with an existing system, such as Elixir’s Logger, please use :gen_event instead.

So, I replaced GenEvent with :gen_event, just like: https://github.com/elixir-lang/elixir/blob/v1.5.2/lib/logger/lib/logger/error_handler.ex

@mitchellhenke
Copy link
Contributor

Thank you for the contribution! ❤️ 💖 💛 💚

@mitchellhenke mitchellhenke merged commit fecce82 into getsentry:master Nov 29, 2017
@redink redink deleted the fix-GenEvent-warning branch November 30, 2017 01:05
@redink
Copy link
Contributor Author

redink commented Dec 7, 2017

Could you make a new release please ? Thanks !

@mitchellhenke
Copy link
Contributor

Yep, I can tomorrow!

@mitchellhenke mitchellhenke mentioned this pull request Dec 7, 2017
Merged
@mitchellhenke
Copy link
Contributor

@redink I've released 6.0.5. If you have any issues, please let me know 🙂

@redink
Copy link
Contributor Author

redink commented Dec 8, 2017

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redink @mitchellhenke