[8.19] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack

[mergify]

PR 2/6

• Enhancement

What does this PR do?

• This is a follow up on Enhancement/5235 insufficient disk handling retry shows underlying error #9122.
• Introduces disk space error type and relevant functions
• Modifies the upgrader unpack step to wrap errors so that the errors are propagated correctly.
• Adds relevant tests, asserts that errors, specifically the disk space error, get propagated up the call chain.

Why is it important?

Non-wrapped errors mask the underlying disk space error when using errors.Is. This is need to address the original issue.

Checklist

• I have read and understood the pull request guidelines of this project.
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

If the agent runs into disk space errors when it is unpacking the downloaded agent archive, the status and fleet ui will show "insufficient disk space" as the error message

How to test this PR locally

• Build for windows, mac, linux

• Install agent (managed and standalone)

• Fill up disk until there is approximately 500mb left

• Trigger upgrade

  • From fleet
  • Cli with remote url and file

• Validate the upgrade detail error message shows insufficient disk error message both in the status output and on fleet ui.

• Run the upgrade, step_unpack tests

Related issues

• Relates Agent reports if there is insufficient disk space during upgrade, cleans up, and prevents upgrade #5235
• Requires enhancement(5235): moved nolint:gosec comment to #9347
• Requires Enhancement/5235 insufficient disk handling retry shows underlying error #9122
• Prerequisite for Enhancement/5235 correctly wrap errors from copyActionDir and copyRunDirectory #9349

---

This is an automatic backport of pull request #9322 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of f70ff02 has failed:

On branch mergify/bp/8.19/pr-9322
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit f70ff023f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   internal/pkg/agent/application/upgrade/upgrade_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/agent/application/upgrade/step_unpack.go
	both modified:   internal/pkg/agent/application/upgrade/step_unpack_test.go
	both modified:   internal/pkg/agent/application/upgrade/upgrade.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[elastic-sonarqube]

Quality Gate passed

Issues
3 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 396dcdf

History

• 💔 Build #26420 failed 29565d7

cc @kaanyalti