enhancement(5235): moved nolint:gosec comment to #9347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the correct line
kaanyalti
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
1 task
5 tasks
kaanyalti
changed the title
|
💚 Build Succeeded
cc @kaanyalti |
ycombinator
approved these changes
Aug 13, 2025
|
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
kaanyalti
deleted the
chore/5235_fix_nolint_gosec_comments_in_step_unpack
branch
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f)
1 task
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f)
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f)
This was referenced Aug 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f)
1 task
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f)
1 task
kaanyalti
added a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f) Co-authored-by: Kaan Yalti <[email protected]>
kaanyalti
added a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f) Co-authored-by: Kaan Yalti <[email protected]>
kaanyalti
added a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f) Co-authored-by: Kaan Yalti <[email protected]>
kaanyalti
added a commit
that referenced
this pull request
Aug 13, 2025
the correct line (cherry picked from commit c1de40f) Co-authored-by: Kaan Yalti <[email protected]>
kaanyalti
added a commit
that referenced
this pull request
Aug 15, 2025
the correct line (cherry picked from commit c1de40f) Co-authored-by: Kaan Yalti <[email protected]>
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the correct line
What does this PR do?
Fixes where nolint comments are in step_unpack.go
Why is it important?
Currently the nolint comments are causing linting errors
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
none
How to test this PR locally
not necessary
Related issues