Skip to content

Conversation

micheltuu
Copy link
Collaborator

@micheltuu micheltuu commented Sep 11, 2025

Changes

Updated go to 1.24.6

The goal after that is to cut 1.49.2 such that I can release it in driftcheck running and fix some security issues

[10:20:15] michel.tu@arca:~/terraform-provider-databricks$ make test
✓ Filling vendor folder with library code ...
✓ Linting source code with https://staticcheck.io/ ...
✓ Running tests ...
∅  . (44ms) (coverage: 0.0% of statements)
✓  dashboards (225ms) (coverage: 76.9% of statements)
∅  catalog/permissions (592ms) (coverage: 0.0% of statements)
✓  logger (368ms) (coverage: 16.7% of statements)
∅  catalog/bindings (592ms) (coverage: 0.0% of statements)
✓  sql/api (361ms) (coverage: 86.9% of statements)
✓  settings (379ms) (coverage: 55.5% of statements)
✓  pools (421ms) (coverage: 98.8% of statements)
✓  libraries (477ms) (coverage: 70.7% of statements)
✓  vectorsearch (470ms) (coverage: 84.8% of statements)
✓  qa (572ms) (coverage: 76.1% of statements)
✓  aws (868ms) (coverage: 81.2% of statements)
✓  secrets (780ms) (coverage: 88.5% of statements)
✓  tokens (838ms) (coverage: 95.6% of statements)
✓  mlflow (875ms) (coverage: 92.9% of statements)
✓  serving (943ms) (coverage: 90.0% of statements)
✓  policies (1.045s) (coverage: 94.9% of statements)
✓  common (1.301s) (coverage: 76.6% of statements)
✓  repos (1.652s) (coverage: 92.2% of statements)
✓  workspace (1.684s) (coverage: 88.5% of statements)
✓  sharing (1.831s) (coverage: 91.9% of statements)
✓  pipelines (2.24s) (coverage: 95.3% of statements)
✓  permissions (2.532s) (coverage: 88.2% of statements)
✓  scim (3.259s) (coverage: 96.0% of statements)
✓  sql (3.442s) (coverage: 86.2% of statements)
✓  commands (3.825s) (coverage: 92.3% of statements)
✓  provider (5.439s) (coverage: 89.7% of statements)
✓  jobs (6.035s) (coverage: 77.4% of statements)
✓  access (6.402s) (coverage: 91.5% of statements)
✓  mws (6.586s) (coverage: 86.5% of statements)
✓  storage (8.956s) (coverage: 95.1% of statements)
✓  clusters (9.314s) (coverage: 76.3% of statements)
✓  internal/acceptance (17.269s) (coverage: 0.0% of statements)
✓  catalog (20.208s) (coverage: 87.5% of statements)
✓  exporter (27.552s) (coverage: 85.0% of statements)

DONE 1985 tests, 212 skipped in 29.674s

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

alexott and others added 3 commits August 29, 2025 08:14
<!-- Summary of your changes that are easy to understand -->

With `go tool` introduced in Go 1.24 it's easier to manage dependencies
to tools used for tests, formatting, linting, etc.

Resolves #4343

NO_CHANGELOG=true

<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [ ] `make test` run locally
- [ ] relevant change in `docs/` folder
- [ ] covered with integration tests in `internal/acceptance`
- [ ] using Go SDK
- [ ] using TF Plugin Framework
@micheltuu micheltuu requested review from a team as code owners September 11, 2025 22:14
@micheltuu micheltuu requested review from parthban-db and removed request for a team September 11, 2025 22:14
@@ -88,7 +88,7 @@ func (cr *CommandResults) Err() error {
if !cr.Failed() {
return nil
}
return fmt.Errorf(cr.Error())
return fmt.Errorf("%s", cr.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of fmt.Errorf("%s", cr.Error()) just use errors.New(cr.Error())

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here and in the other places, thank you for the suggestion

@tanmay-db tanmay-db changed the title Update go in v1.49.x [Internal] Update go in v1.49.x Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants