Only warn if there is an actuall configuration problem #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to drop Podman logrus level to "warn". But the ocicni log level by default prints out a Warning message on every run. sudo podman --log-level=warn run alpine echo hello [sudo] password for dwalsh: WARN[0000] Default CNI network name podman is unchangeable hello Since this is an expected behaviour, not a mis configuraiton, it should be dropped to Info. We should only print Warnings, when there is actuall configuration errors or changes the user could act upon. Signed-off-by: Daniel J Walsh <[email protected]>
openshift-ci-robot
added
dco-signoff: yes
|
/release-note-none |
openshift-ci-robot
added
release-note-none
|
LGTM |
rhatdan
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to drop Podman logrus level to "warn". But the ocicni
log level by default prints out a Warning message on every run.
sudo podman --log-level=warn run alpine echo hello
[sudo] password for dwalsh:
WARN[0000] Default CNI network name podman is unchangeable
hello
Since this is an expected behaviour, not a mis configuraiton, it should
be dropped to Info. We should only print Warnings, when there is actuall
configuration errors or changes the user could act upon.
Signed-off-by: Daniel J Walsh [email protected]