Skip to content

fixes log levels, adds a few tests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

fixes log levels, adds a few tests #76

merged 1 commit into from
Dec 3, 2020

Conversation

wgahnagl
Copy link

@wgahnagl wgahnagl commented Jul 9, 2020 •
edited
Loading

Signed-off-by: Skyler Clark [email protected]

none

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 9, 2020
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 9, 2020
@haircommander
Copy link
Member

@saschagrunert now the release note plugin is enabled on the org, we get hit here too. do you know if it's possible to only require it in cri-o repo?

@wgahnagl wgahnagl changed the title [WIP] fixes log levels, adds a few tests fixes log levels, adds a few tests Jul 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2020
@saschagrunert
Copy link
Member

@saschagrunert now the release note plugin is enabled on the org, we get hit here too. do you know if it's possible to only require it in cri-o repo?

Yeah it should be possible, OTOH we could also move the PR template over here, WDYT?

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 21, 2020
@wgahnagl
Copy link
Author

@umohnani8 @saschagrunert @saschagrunert @mrunalp PTAL

@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 30, 2020
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 30, 2020
@wgahnagl wgahnagl force-pushed the log-improvements branch 3 times, most recently from 543fa39 to 82dc563 Compare October 30, 2020 18:50
saschagrunert
saschagrunert approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umohnani8
Copy link
Member

LGTM

1 similar comment
@haircommander
Copy link
Member

LGTM

fidencio
fidencio reviewed Nov 6, 2020
View reviewed changes
Copy link

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgahnagl, I've added a few comments. Please, bear with me as I'm slightly new to the code base, so the questions may not actually make sense.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2020
@umohnani8
Copy link
Member

@wgahnagl needs a rebase

@umohnani8
Copy link
Member

@haircommander PTAL

@haircommander
Copy link
Member

I think you'll need to rebase on master, as it looks like there'll be some conflic t with #82

@wgahnagl
Copy link
Author

wgahnagl commented Dec 2, 2020

II've rebased, but there's no updates left to do!

@umohnani8
Copy link
Member

@haircommander github is not complaining about any conflicts as well, so this should be ready to go :)

@umohnani8
Copy link
Member

/approve

@fidencio
Copy link

fidencio commented Dec 2, 2020

/lgtm, thanks @wgahnagl!

@haircommander
Copy link
Member

LGTM, @rhatdan PTAL since you just worked in this area

@rhatdan
Copy link
Contributor

rhatdan commented Dec 3, 2020

/lgtm
This is fine, although I would prefer if errors were returned rather then just logged.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
fidencio
fidencio suggested changes Dec 3, 2020
View reviewed changes
Copy link

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgahnagl, let me take my LGTM back (sorry about that).

I think you did the changes locally but ended up not pishing them.

@rhatdan
Copy link
Contributor

rhatdan commented Dec 3, 2020

/approve

@rhatdan rhatdan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rhatdan, saschagrunert, umohnani8, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b980886 into cri-o:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

@sameo sameo Awaiting requested review from sameo

+1 more reviewer

@fidencio fidencio fidencio requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wgahnagl @haircommander @saschagrunert @umohnani8 @fidencio @rhatdan @openshift-ci-robot @openshift-merge-robot