Skip to content

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jun 5, 2025

Description Of Changes

This commit adds additional parameter to the function, with the default value that maintains full backwards compatibility.

Motivation and Context

This allows for greater control over the arguments that are passed through when setting up the file association. This allows for scenarios where you might need to do something like -o "%1" when the default is to do something like "%1" "%*".

Testing

This change allows for full backwards compatability, so no additional testing has been completed.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #1176

@gep13 gep13 requested a review from AdmiringWorm June 5, 2025 15:02
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gep13
Copy link
Member Author

gep13 commented Jun 5, 2025

We have added the original author of this commit (which has been updated by myself) as a co-author on the commit in this PR. As such, the CLA bot is looking for their signature. We are going to bypass this check, since it is not needed in this instance. The co-author was really a hat-tip to their original work, and does require a signature on the CLA.

This commit adds additional parameter to the function, with the default
value that maintains full backwards compatibility.

This allows for greater control over the arguments that are passed
through when setting up the file association.  This allows for scenarios
where you might need to do something like `-o "%1"` when the default is
to do something like `"%1" "%*"`.

Co-authored-by: bazzilic <[email protected]>
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 099c10b into chocolatey:develop Jun 5, 2025
4 of 5 checks passed
@gep13 gep13 deleted the issue1176 branch June 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass multiple arguments to the Install-ChocolateyFileAssociation PowerShell function
4 participants