Skip to content

Conversation

bazzilic
Copy link
Contributor

@bazzilic bazzilic commented Feb 24, 2017

This PR makes Install-ChocolateyFileAssociation more configurable while maintaining full backwards compatibility. It introduces a new optional parameter -PassedArguments that specifies which CLI arguments should be given to the executable and how. If parameter is omitted, the old behavior is preserved.

Certain applications require something more sophisticated than app.exe "%1", some need, e.g., app.exe -o "%1". This will make it possible to register associations for them too.

Fixes #1176

@bazzilic bazzilic changed the title A more configurable behavior of the function A more configurable behavior of Install-ChocolateyFileAssociation Feb 24, 2017
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bazzilic - What issue does this fix? Please read over contributing if you haven't had a chance - we'll need an issue we can point to on this one

@ferventcoder
Copy link
Member

More on the issue - we need something to mention in our changelog, that users can comment on, so just follow up with a ticket, then fix up these commits to reference that issue according to CONTRIBUTING. Thanks!

@bazzilic bazzilic changed the title A more configurable behavior of Install-ChocolateyFileAssociation (GH-1176) A more configurable behavior of Install-ChocolateyFileAssociation Mar 2, 2017
@bazzilic
Copy link
Contributor Author

bazzilic commented Mar 2, 2017

@ferventcoder done! (at least, I think so)

This commit adds additional parameter to the function, with the default
value that maintains full backwards compatibility.
@bazzilic
Copy link
Contributor Author

Rebased this onto latest master. Hopefully, it will get merged one day.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gep13 gep13 changed the title (GH-1176) A more configurable behavior of Install-ChocolateyFileAssociation (#1176) A more configurable behavior of Install-ChocolateyFileAssociation Oct 15, 2021
@gep13
Copy link
Member

gep13 commented Jun 5, 2025

As follow up PR has been created here:

#3684

Since this PR was created using the master branch, it is not possible to update this PR with the changes that have been made in the develop branch since this PR was created. As a result, I am going to go ahead and close this PR out, and continue the work over in the new PR.

Thank you very much for the prod to get this completed. Around here, the wheels do indeed turn slowly, but thankfully, they do still turn! 😄

@gep13 gep13 closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass multiple arguments to the Install-ChocolateyFileAssociation PowerShell function
4 participants