Skip to content

Conversation

choover-broad
Copy link
Contributor

@choover-broad choover-broad commented Jun 10, 2025

Downgrade zitadel/oidc from v3.39.0 -> v3.36.1.

Version 3.37.0 breaks the ArgoCD Beehive auth provider -- attempts to click the Login via Beehive button return the error oauth2: "invalid_request" "code_verifier required".

Testing

I verified that this PR works by deploying it. No more broken auth :)

@choover-broad choover-broad requested a review from a team as a code owner June 10, 2025 13:16
Copy link

Copy link

No API changes detected

Copy link

Published image from 32c844d (merge c9d28fe):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.6.38-c9d28fe
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.6.38-c9d28fe

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (d405fea) to head (32c844d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files         292      292           
  Lines       16503    16503           
=======================================
  Hits        10199    10199           
  Misses       5528     5528           
  Partials      776      776           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@JoshEvans33 JoshEvans33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@choover-broad choover-broad merged commit 503eac8 into main Jun 10, 2025
28 checks passed
@choover-broad choover-broad deleted the ch-DDO-4139 branch June 10, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants