Warn when schedule set is empty #20985
Open
+116
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janis-bhm
added
A-ECS
hymm
reviewed
Sep 12, 2025
| @@ -1752,6 +1764,7 @@ impl ScheduleBuildSettings { | |||
| Self { | |||
| ambiguity_detection: LogLevel::Ignore, | |||
| hierarchy_detection: LogLevel::Warn, | |||
| empty_set_detection: true, | |||
There was a problem hiding this comment.
We should consider whether this should be on by default or not. Bevy will have some empty sets depending on what features are enabled.
There was a problem hiding this comment.
Agreed. There's quite a bit of nuance here. Libraries might also deliberately export empty sets.
There was a problem hiding this comment.
That makes sense. I think it would be nice if there was a way to distinguish user-inserted sets from library or internal sets, though I'm not sure how that would be accomplished.
alice-i-cecile
added
the
X-Contentious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
addresses #19979
Solution
ScheduleBuildWarningfor empty setsTesting
I've added 4 tests testing different configurations of system sets.
Open Questions
Should this be a boolean configuration or a
LogLevellike the otherScheduleBuildWarnings?