Skip to content

Conversation

Leinnan
Copy link
Contributor

@Leinnan Leinnan commented Sep 12, 2025

Objective

Fixes #20952

Solution

Improve flow for getting type path. Add new test to make sure it will work later on.

Testing

New test is added to confirm that the solution works, I wrote the test first to check if I have the same issue as described in report. It was that and the fix was provided by @natepiano so my work here is mostly test.

Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@janhohenheim janhohenheim added A-Reflection Runtime information about types A-Editor Graphical tools to make Bevy games D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Dev-Tools Tools used to debug Bevy applications. labels Sep 12, 2025
@SkiFire13
Copy link
Contributor

Can we also update TypedReflectDeserializer to use ReflectFromReflect if present, so that we improve the UX for all users of TypedReflectDeserializer and not just BRP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Dev-Tools Tools used to debug Bevy applications. A-Editor Graphical tools to make Bevy games A-Reflection Runtime information about types D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BRP Issue: Components with only Reflect cannot be spawned/inserted
4 participants