-
Notifications
You must be signed in to change notification settings - Fork 29
Propagate ClusterID to Cloud Map & Endpoints #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matthewgoodman13
merged 39 commits into
aws:main
from
matthewgoodman13:reconcileclusterid
Jul 29, 2022
Merged
Propagate ClusterID to Cloud Map & Endpoints #165
matthewgoodman13
merged 39 commits into
aws:main
from
matthewgoodman13:reconcileclusterid
Jul 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added managed by label - issue 110 (aws#139)
…thewgoodman13/aws-cloud-map-mcs-controller-for-k8s into multicluster-clusterproperty
…thewgoodman13/aws-cloud-map-mcs-controller-for-k8s into multicluster-clusterproperty
…thewgoodman13/aws-cloud-map-mcs-controller-for-k8s into multicluster-clusterproperty
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 74.52% 72.65% -1.87%
==========================================
Files 15 15
Lines 1480 1558 +78
==========================================
+ Hits 1103 1132 +29
- Misses 300 342 +42
- Partials 77 84 +7
Continue to review full report at Codecov.
|
astaticvoid
reviewed
Jul 14, 2022
runakash
reviewed
Jul 18, 2022
runakash
requested changes
Jul 25, 2022
astaticvoid
reviewed
Jul 27, 2022
runakash
reviewed
Jul 29, 2022
runakash
approved these changes
Jul 29, 2022
astaticvoid
added a commit
that referenced
this pull request
Jul 31, 2022
This reverts commit 0354a3d.
runakash
pushed a commit
to runakash/aws-cloud-map-mcs-controller-for-k8s
that referenced
this pull request
Jun 20, 2025
ClusterId, ClusterSetId getting exported to Cloud Map & getting propagated to endpoints as CLUSTER_ID and CLUSTERSET_ID attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affiliated with Issue 47
TLDR:
ClusterID getting exported to Cloud Map & getting propagated to endpoints as an
CLUSTER_ID
attributeDescription of changes:
about.k8s.io
)serviceexport_controller.go
, we now watch for changes in the ClusterProperty attribute, and when there is a change, we reconcile all endpoints. This works for adding and removing of a ClusterProperty object.kubectl apply -f config/samples/about_v1alpha1_clusterproperty.yaml
Notes:
No error handling introduced yet and no errors will be thrown yet for no ClusterID being defined other than when the service is being exported. No unit tests in this PR either.CLUSTER_ID
attribute in the endpointsuite_test.go
, changes needed to be made to not include the clusterproperty CRD for testing. Special tests will need to be constructed to manually add the annotation to be allowed to use '.k8s.io' suffix.Testing:
make test
runs without error