Added managed by label - issue 110 #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 73.98% 74.05% +0.07%
==========================================
Files 15 15
Lines 1449 1453 +4
==========================================
+ Hits 1072 1076 +4
Misses 300 300
Partials 77 77
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
runakash
reviewed
Jun 13, 2022
runakash
previously approved these changes
Jun 13, 2022
runakash
approved these changes
Jun 13, 2022
astaticvoid
reviewed
Jun 14, 2022
| LabelEndpointSliceManagedBy = "endpointslice.kubernetes.io/managed-by" | ||
|
|
||
| // ValueEndpointSliceManagedBy indicates the name of the entity that manages the EndpointSlice. | ||
| ValueEndpointSliceManagedBy = "aws-cloud-map-mcs-controller-for-k8s" |
There was a problem hiding this comment.
According to spec any unique string is fine, although searching for examples of other controllers that set this value it seems somewhat conventional to use a uri.
matthewgoodman13
added a commit
to matthewgoodman13/aws-cloud-map-mcs-controller-for-k8s
that referenced
this pull request
Jun 17, 2022
Added managed by label - issue 110 (aws#139)
runakash
pushed a commit
to runakash/aws-cloud-map-mcs-controller-for-k8s
that referenced
this pull request
Jun 20, 2025
* Added managed by label - issue 110 * Update utils.go * rename constants * Update cloudmap_controller_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #110
Description of changes:
Added the
managed-bylabel as per issue. Value set to our controlleraws-cloud-map-mcs-controller-for-k8s.Added test to assert that the label was added to any new endpointSlice.