Skip to content

chore(tests): add unit tests for isAppHealthy of ApplicationSet #24487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(tests): add unit tests for isAppHealthy of ApplicationSet #24487

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
965286e
add unit tests for isApplicationHealthy
ranakan19 Aug 12, 2025
e7b4cab
Merge branch 'master' of https://github.com/argoproj/argo-cd into app…
ranakan19 Aug 12, 2025
3460a65
Merge branch 'master' into appsetCache
ranakan19 Sep 9, 2025
56f3078
Merge branch 'master' into appsetCache
ranakan19 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
273 changes: 273 additions & 0 deletions applicationset/controllers/applicationset_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7650,3 +7650,276 @@ func TestIsRollingSyncDeletionReversed(t *testing.T) {
})
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TestIsApplicationHealthy tests if the application is healthy.

nit

func TestIsApplicationHealthy(t *testing.T) {
tests := []struct {
name string
app v1alpha1.Application
expectedResult bool
}{
{
name: "healthy application with synced status and succeeded operation",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: true,
},
{
name: "healthy application with synced status and no operation",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: nil,
},
},
expectedResult: true,
},
{
name: "healthy application with unknown sync status and succeeded operation",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeUnknown,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: true,
},
{
name: "degraded health status",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusDegraded,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "progressing health status",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusProgressing,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "missing health status",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusMissing,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "unknown health status",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusUnknown,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "healthy but out of sync",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "healthy but out of sync",
name: "healthy but out of sync",

I don't know where it would be suitable, but we should mention somewhere that a healthy status doesn't confirm that an application is healthy.

app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeOutOfSync,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "healthy and synced but operation running",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationRunning,
},
},
},
expectedResult: false,
},
{
name: "healthy and synced but operation failed",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationFailed,
},
},
},
expectedResult: false,
},
{
name: "healthy and synced but operation error",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationError,
},
},
},
expectedResult: false,
},
{
name: "all conditions failing",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusDegraded,
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeOutOfSync,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationFailed,
},
},
},
expectedResult: false,
},
{
name: "empty health status string",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: "",
},
Sync: v1alpha1.SyncStatus{
Status: v1alpha1.SyncStatusCodeSynced,
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: false,
},
{
name: "empty sync status string",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: "",
},
OperationState: &v1alpha1.OperationState{
Phase: common.OperationSucceeded,
},
},
},
expectedResult: true, // empty sync status is not "OutOfSync" so it passes
},
{
name: "completely empty application status",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{},
},
expectedResult: false,
},
{
name: "no Operation state",
app: v1alpha1.Application{
Status: v1alpha1.ApplicationStatus{
Health: v1alpha1.AppHealthStatus{
Status: health.HealthStatusHealthy,
},
Sync: v1alpha1.SyncStatus{
Status: "",
},
},
},
expectedResult: true, // no OperationState defaults OperationPhaseString to "", thus passes
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := isApplicationHealthy(tt.app)
assert.Equal(t, tt.expectedResult, result, "isApplicationHealthy() result mismatch")
})
}
}
Loading