chore(tests): add unit tests for isAppHealthy of ApplicationSet #24487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kanika Rana <[email protected]>
…setCache Signed-off-by: Kanika Rana <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
nitishfy
reviewed
Sep 10, 2025
| @@ -7650,3 +7650,276 @@ func TestIsRollingSyncDeletionReversed(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| // TestIsApplicationHealthy tests if the application is healthy. |
nit
nitishfy
reviewed
Sep 10, 2025
| expectedResult: false, | ||
| }, | ||
| { | ||
| name: "healthy but out of sync", |
There was a problem hiding this comment.
Suggested change
| name: "healthy but out of sync", | |
| name: "healthy but out of sync", |
I don't know where it would be suitable, but we should mention somewhere that a healthy status doesn't confirm that an application is healthy.
nitishfy
reviewed
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isApplicationHealthy() is used by appSyncEnabledForNextStep() in progressive sync to determine application in next step is ready to be synced. While investigating another issue, I noticed that this function doesn’t currently have dedicated tests — adding them here should be helpful.
Checklist: