Skip to content

fix(repositories): use list api to search for repository #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

fix(repositories): use list api to search for repository #668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b956ae7
fix(repositories): use list api to search for repository)
the-technat Jun 17, 2025
f734a11
Merge branch 'main' into issue/556
the-technat Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions argocd/resource_argocd_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,24 +83,33 @@ func resourceArgoCDRepositoryRead(ctx context.Context, d *schema.ResourceData, m
}

tokenMutexConfiguration.RLock()
r, err := si.RepositoryClient.Get(ctx, &repository.RepoQuery{
Repo: d.Id(),
AppProject: d.State().Attributes["project"],
ForceRefresh: true,
})
repos, err := si.RepositoryClient.List(ctx, &repository.RepoQuery{})
tokenMutexConfiguration.RUnlock()

if err != nil {
// Repository has already been deleted in an out-of-band fashion
if strings.Contains(err.Error(), "NotFound") {
d.SetId("")
return nil
var finalRepo *application.Repository

if repos != nil {
if len(repos.Items) >= 1 {
for _, repo := range repos.Items {
if repo.Repo == d.Id() {
finalRepo = repo
}
}
}
}

if finalRepo == nil {
// if finalRepo is empty this means that either there no repositories at all or the desired one isn't in the list
// that means we clear it from state and terraform will create it if desired
d.SetId("")
return nil
}

if err != nil {
return argoCDAPIError("read", "repository", d.Id(), err)
}

if err = flattenRepository(r, d); err != nil {
if err = flattenRepository(finalRepo, d); err != nil {
return errorToDiagnostics(fmt.Sprintf("failed to flatten repository %s", d.Id()), err)
}

Expand Down