fix(repositories): use list api to search for repository #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
changed the title
Signed-off-by: Nathanael Liechti <[email protected]>
the-technat
requested review from
oboukili,
onematchfox,
blakepettersson and
mkilchhofer
as code owners
mkilchhofer
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
The repository API returns
403if a repository doesn't exist due to security reasons. That confuses the provider and leads to cases where the provider errors instead of detecting a drift between desired and actual state.Context for this can be found in multiple sources:
ListAPI endpoint argoproj/argo-cd#13363Somehow I'm not able to filter the list of repositories with the given filters (it always returns all repos), thus I didn't filter at all.