Skip to content

feat: Add support for destination service accounts #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jul 31, 2025
Merged

feat: Add support for destination service accounts #567

merged 34 commits into from
Jul 31, 2025

Conversation

nimjor
Copy link
Contributor

@nimjor nimjor commented Mar 11, 2025

No description provided.

Jordan Nimlos and others added 3 commits March 11, 2025 07:53
@nimjor nimjor force-pushed the feat/dest-svc-accts branch from 4f57aad to 34234f1 Compare March 11, 2025 12:53
@mkilchhofer mkilchhofer changed the title Feat: Add support for destination service accounts feat: Add support for destination service accounts Mar 12, 2025
@mkilchhofer
Copy link
Collaborator

mkilchhofer commented Mar 12, 2025 •
edited
Loading

Xref:

add updated docs
e6aa0ea 
Signed-off-by: Jordan Nimlos <[email protected]>
@nimjor nimjor force-pushed the feat/dest-svc-accts branch from 04d7ba1 to e6aa0ea Compare March 12, 2025 13:23
@the-technat the-technat mentioned this pull request May 9, 2025
Closed
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale label Jul 2, 2025
@mkilchhofer mkilchhofer added on-hold Issues or Pull Requests with this label will never be considered stale and removed Stale labels Jul 3, 2025
nimjor and others added 7 commits July 14, 2025 13:50
@nimjor
Merge branch 'main' into feat/dest-svc-accts
5ab2153 
Signed-off-by: nimjor <[email protected]>
separate version and settings support checks with a single wrapper
cf41b5c 
Signed-off-by: Jordan Nimlos <[email protected]>
fix linting issues
c472f4e 
Signed-off-by: Jordan Nimlos <[email protected]>
@blakepettersson
chore: add ability to optionally filter tests (argoproj-labs#684)
0113902 
In the various `Makefile` tasks, add an option to filter out tests if
necessary. I also fixed a few tests which were failing when running
unit tests where the config params require a k8s environment to be up
and running.

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Jordan Nimlos <[email protected]>
@renovate
fix(deps): update module github.com/argoproj/argo-cd/v3 to v3.0.11 (a…
fbc3f34 
…rgoproj-labs#664)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jordan Nimlos <[email protected]>
@blakepettersson
chore: migrate to terraform-plugin-testing (argoproj-labs#687)
b55e770 
* chore: migrate to terraform-plugin-testing

It gets pretty messy trying to mix `terraform-plugin-testing` with the
older `terraform-plugin-sdk` testing framework, so let's just use
`terraform-plugin-testing` for both the old resources as well as the new ones.

Signed-off-by: Blake Pettersson <[email protected]>

* chore: ignore fields

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Jordan Nimlos <[email protected]>
add doc comments to IsVersionSupported and IsSettingSupported funcs
cc917f4 
Signed-off-by: Jordan Nimlos <[email protected]>
@nimjor nimjor force-pushed the feat/dest-svc-accts branch from 04714d2 to cc917f4 Compare July 17, 2025 18:11
onematchfox
onematchfox reviewed Jul 22, 2025
View reviewed changes
onematchfox
onematchfox requested changes Jul 23, 2025
View reviewed changes
@the-technat
Copy link
Collaborator

@nimjor we just merged a refactoring PR (#685) that migrated some resources to the terraform-plugin-framework and thus had to move the server_interface back to the SKDv2 code. I'm afraid that means some of your code has to be moved as well 🙈.

nimjor and others added 8 commits July 30, 2025 11:35
@nimjor
Merge branch 'main' into feat/dest-svc-accts
fcd7c65
revert unstable feature test workflows
d091b12 
Signed-off-by: Jordan Nimlos <[email protected]>
revert feature constraint server settings component
aa95ba1 
Signed-off-by: Jordan Nimlos <[email protected]>
missed cleanup IsVersionSupported func, add nil check on fc.MinVersion
c2d7374 
Signed-off-by: Jordan Nimlos <[email protected]>
avoid panic in expandDestinationServiceAccounts
5d92161 
Signed-off-by: Jordan Nimlos <[email protected]>
rm kubernetes tf provider usage in test
7e696ce 
Signed-off-by: Jordan Nimlos <[email protected]>
check feature support on resource create/update
4666211 
Signed-off-by: Jordan Nimlos <[email protected]>
add fc.MinVersion nil check to new server_interface
600bd6f 
Signed-off-by: Jordan Nimlos <[email protected]>
@nimjor
Copy link
Contributor Author

nimjor commented Jul 30, 2025

@nimjor we just merged a refactoring PR (#685) that migrated some resources to the terraform-plugin-framework and thus had to move the server_interface back to the SKDv2 code. I'm afraid that means some of your code has to be moved as well 🙈.

@the-technat let me know if there's anything specific in this PR in the current state that needs to get moved.

onematchfox
onematchfox approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@onematchfox onematchfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nimjor!

the-technat
the-technat approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@the-technat the-technat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nimjor for your patience!

@the-technat the-technat merged commit 740629d into argoproj-labs:main Jul 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onematchfox onematchfox onematchfox approved these changes

@the-technat the-technat the-technat approved these changes

@oboukili oboukili Awaiting requested review from oboukili oboukili is a code owner

@blakepettersson blakepettersson Awaiting requested review from blakepettersson blakepettersson is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

Assignees
No one assigned
Labels
on-hold Issues or Pull Requests with this label will never be considered stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nimjor @mkilchhofer @the-technat @onematchfox @blakepettersson