feat(tests): align workflow file with framework skaffold repo #563
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
requested review from
oboukili,
onematchfox,
blakepettersson and
mkilchhofer
as code owners
Signed-off-by: Nathanael Liechti <[email protected]>
the-technat
force-pushed
the
tests/align-to-framework
branch
from
cb3d37a to
5d35bf9
Compare
mkilchhofer
approved these changes
Mar 11, 2025
nimjor
pushed a commit
to nimjor/terraform-provider-argocd
that referenced
this pull request
Mar 11, 2025
…oj-labs#563) Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: Jordan Nimlos <[email protected]>
the-technat
added a commit
that referenced
this pull request
Jul 31, 2025
* upgrade argo version and add support for dest svc accts Signed-off-by: Jordan Nimlos <[email protected]> * feat(tests): align workflow file with framework skaffold repo (#563) Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: Jordan Nimlos <[email protected]> * feat: align tools folder with scaffold repo (#565) Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: Jordan Nimlos <[email protected]> * include flattener function for dsa Signed-off-by: Jordan Nimlos <[email protected]> * add updated docs Signed-off-by: Jordan Nimlos <[email protected]> * go mod tidy and fix generate/build Signed-off-by: Jordan Nimlos <[email protected]> * add argocd settings api client Signed-off-by: Jordan Nimlos <[email protected]> * add settings check to feature constraints Signed-off-by: Jordan Nimlos <[email protected]> * separate version and settings support checks with a single wrapper Signed-off-by: Jordan Nimlos <[email protected]> * fix linting issues Signed-off-by: Jordan Nimlos <[email protected]> * chore: add ability to optionally filter tests (#684) In the various `Makefile` tasks, add an option to filter out tests if necessary. I also fixed a few tests which were failing when running unit tests where the config params require a k8s environment to be up and running. Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: Jordan Nimlos <[email protected]> * fix(deps): update module github.com/argoproj/argo-cd/v3 to v3.0.11 (#664) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Jordan Nimlos <[email protected]> * chore: migrate to terraform-plugin-testing (#687) * chore: migrate to terraform-plugin-testing It gets pretty messy trying to mix `terraform-plugin-testing` with the older `terraform-plugin-sdk` testing framework, so let's just use `terraform-plugin-testing` for both the old resources as well as the new ones. Signed-off-by: Blake Pettersson <[email protected]> * chore: ignore fields Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: Jordan Nimlos <[email protected]> * add doc comments to IsVersionSupported and IsSettingSupported funcs Signed-off-by: Jordan Nimlos <[email protected]> * separate unstable feature acceptance tests from stable ones Signed-off-by: Jordan Nimlos <[email protected]> * re-add dropped ApplicationSourceName feature Signed-off-by: Jordan Nimlos <[email protected]> * revert unstable feature test workflows Signed-off-by: Jordan Nimlos <[email protected]> * revert feature constraint server settings component Signed-off-by: Jordan Nimlos <[email protected]> * missed cleanup IsVersionSupported func, add nil check on fc.MinVersion Signed-off-by: Jordan Nimlos <[email protected]> * avoid panic in expandDestinationServiceAccounts Signed-off-by: Jordan Nimlos <[email protected]> * rm kubernetes tf provider usage in test Signed-off-by: Jordan Nimlos <[email protected]> * check feature support on resource create/update Signed-off-by: Jordan Nimlos <[email protected]> * add fc.MinVersion nil check to new server_interface Signed-off-by: Jordan Nimlos <[email protected]> --------- Signed-off-by: Jordan Nimlos <[email protected]> Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: nimjor <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Jordan Nimlos <[email protected]> Co-authored-by: Nathanael Liechti <[email protected]> Co-authored-by: Jordan Nimlos <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to align the test/release file with the upstream https://github.com/hashicorp/terraform-provider-scaffolding-framework repo.
This changes the following:
Relates to #440