-
Notifications
You must be signed in to change notification settings - Fork 1.6k
projects: ad9084_ebz: Initial design #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bluncan
wants to merge
6
commits into
main
Choose a base branch
from
dev_apollo_pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfde082
to
00c664a
Compare
13 tasks
00c664a
to
f847ce1
Compare
FilipG24
reviewed
Sep 8, 2025
tfcollins
reviewed
Sep 10, 2025
tfcollins
suggested changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few invalid paths when cloned repo isn't called hdl
Adds AD9084-EBZ (Apollo) base design for the following carriers: - vcu118 - vck190 - vpk180 - fm87 Signed-off-by: Bogdan Luncan <[email protected]>
Allow to be sourced from testbench Signed-off-by: Jorge Marques <[email protected]>
Signed-off-by: Jorge Marques <[email protected]>
Simplifies identifying which SPI are 4-wire or 3-wire. Also, for vck190, since the SPI interface only has 3 outputs, route adf4030 to the third. The adf4030 linux driver defaults to 4-wire, and 3-wire (datasheet default) can be set through devicetree property adi,spi-3wire-enable. Signed-off-by: Jorge Marques <[email protected]>
…/4w and unused slave devices Signed-off-by: Filip Gherman <[email protected]>
f847ce1
to
677505b
Compare
Signed-off-by: Bogdan Luncan <[email protected]>
677505b
to
d22e570
Compare
gastmaier
reviewed
Sep 11, 2025
|
||
ad9084_ebz_spi #( | ||
.NUM_OF_SLAVES(3), | ||
.IS_4WIRE(3'b101) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
.IS_4WIRE(3'b101) | |
.IS_4WIRE(3'b000) # adf4030 hmc7044 adf4382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the AD9084 (Apollo) design.
Requires the following PRs to be merged to main before this one:
After they are merged, I'll rebase this branch and re-check that the projects are building.
PR Type
PR Checklist