-
Notifications
You must be signed in to change notification settings - Fork 1
docs: UR hardware interface guide - Dashboard & Hand Guiding controller #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/ur
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some first comments, structure looks good to me though, we can keep adding content
|
||
# Hardware Interface | ||
|
||
TBD: There is already a [page](../../concepts/building-blocks/hardware-interfaces.md) on hardware interfaces. Are these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with minor duplication here and there, I think it's quite likely people land in this page so giving a direction to the original page would make sense. That is, perhaps we link to that page, but it's ok to have the current text too
Co-authored-by: Vaios Papaspyros <[email protected]>
|
||
## Hand Guiding controller | ||
|
||
NOTE: Did not really know what to write in the next paragraph, the reason we did not just implement simple freedrive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we implemented the hand guiding controller is that the freedrive feels a bit janky sometimes, whereas the admittance control is much smoother and yields nicer trajectories/recordings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't want to phrase it like that, seems like we are trash-talking UR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean fair enough but we also had a lot of conversations with people from UR where they admitted that this is not usable and they'd like to make it better
I was inspired in the airplane and had a go at this. Rewrote the first part of the guide until
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for keeping this up. I suppose there are still some todos to be resolved, but seems on track
Co-authored-by: Vaios Papaspyros <[email protected]>
Description
Includes the dashboard controller example. Many TODOs and comments left inside but, as discussed, it's better to start reviewing before it gets too large.
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: