-
-
Notifications
You must be signed in to change notification settings - Fork 126
Enumerate tutorials and rebuild #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is an error in the build of The line plot(sol,vars=(:x,:y,:z)) fails with this error:
|
There are errors in the build of The line using PuMaS fails:
Trying to install import Pkg; Pkg.add("PuMaS")
|
There are errors in the build of The code using DecFP
prob_ode_decfplinear = ODEProblem(f,Dec128(1)/Dec128(2),(Dec128(0.0),Dec128(1.0)),Dec128(1.01))
sol =solve(prob_ode_decfplinear,Tsit5()) fails:
The code using Decimals
prob_ode_decimallinear = ODEProblem(f,[decimal("1.0")]./[decimal("2.0")],(0//1,1//1),decimal(1.01))
sol =solve(prob_ode_decimallinear,RK4(),dt=1/2^(6)) #Fails fails as well, although it seems to be known (comment
|
There are errors in The code t + sqrt(t) fails:
The code using DifferentialEquations
f = (y,p,t) -> 0.5*y
u0 = 1.5u"N"
prob = ODEProblem(f,u0,(0.0u"s",1.0u"s"))
sol = solve(prob,Tsit5()) fails:
|
Keep the old PDF, because the PDF fails to build.
Only the PDF fails to build for I get this LaTeX error:
|
Keep the old PDF because the PDF fails to build.
The PDF fails to build for I get this LaTeX error:
Furthermore, the line addjumps!(rn, build_regular_jumps=false, minimal_jumps=true) fails:
|
Keep the old PDF because it fails to build.
The PDF fails to build for
Furthermore, I needed to add the line |
Only the PDF fails to build for I get this LaTeX error:
|
All the issues with the rebuild have been put in separate commits/comments. How can we further proceed? I will be back on Monday. |
The TeX issues should get upstreamed. I was just concerned about finish before so I forgot to. I ran into the same ones.
Oh no! Thanks for catching that.
that sounds like a genuine bug :(. Should get an issue.
I think that section is marked as "will fail" IIRC.
Those are supposed to fail IIRC
This should get an issue. |
Better than before, so IMO let's merge and keep improving :) |
The README links might need an update |
@ChrisRackauckas By getting upstreamed you mean these issues should get reported to the |
Yes |
One of the PDF issues has been fixed in #63. The hopefully last one arises from the option |
I think that block can be set to be selectively added only when html or something like that |
I did not have any success fixing the LaTeX issues in
where I tried to change that And I'm not sure, if this is not something that should be fixed by I have opened an issue ticket JunoLab/Weave.jl#228 about expected failures. This would allow us to indicate the code which is expected to fail, without generating a warning by What about the issue with |
You don't need PuMaS for that tutorial. That was an accident. It's a private repo. |
So should I simply remove this last section Use Case: PuMaS.jl from the tutorial and rebuild? |
Yup, that was just from a presentation |
The remaining LaTeX issue has been reported to |
This PR is the continuation of #61.
In a first step, I have enumerated all the tutorial files in
tutorials/
,html/
,notebook/
,pdf/
,script/
as suggested in #60.The second commit rebuilds all the tutorials that could be built without unintended
Weave.jl
warnings/errors.The following tutorials could not be built without errors, so I will add them in seperate commits to this PR, and we can figure out what to do:
introduction/05-formatting_plots
models/03-diffeqbio_I_introduction
models/04-diffeqbio_II_networkproperties
models/06-pendulum_bayesian_interface
models/07-outer_solar_system
ode_extras/ModelingToolkit
type_handling/01-number_types
type_handling/03-unitful