-
-
Notifications
You must be signed in to change notification settings - Fork 231
Improve Printing of Uninitialized Variables #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DhairyaLGandhi
wants to merge
6
commits into
SciML:master
Choose a base branch
from
DhairyaLGandhi:dg/Dprint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−2
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c4f770
chore: improve printing of uninitialized variables
DhairyaLGandhi f137b1a
chore: add string manipulation hack
DhairyaLGandhi ce933f8
chore: check if sys is scheduled
DhairyaLGandhi 3caeae1
Merge branch 'master' into dg/Dprint
DhairyaLGandhi bbce298
test: check Differential(x) in docstring
DhairyaLGandhi a63fb73
chore: use Symbolic instead of Symbol
DhairyaLGandhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be gated behind
isscheduled(sys)
so that printing the error doesn't error if the system isn'tmtkcompile
d? It could also use the string manipulation "hack" discussed earlier in that case (or if the inverse map doesn't have the appropriate entry, as is the case for algebraic variables)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that error check happen earlier (ie before we get this far in the problem construction). Also note that any variables not in the schedule get passed through as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems do not require the system to be
mtkcompile
d.Yeah, but we can still print them better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is added back in f137b1a