Improve Printing of Uninitialized Variables #3920
Conversation
|
@asinghvi17 can you try this out for your MWE please |
DhairyaLGandhi
changed the title
src/utils.jl
Outdated
| Else returns the variable as-is. | ||
| """ | ||
| function underscore_to_D(v::AbstractVector, sys) | ||
| maps = get_schedule(sys).dummy_sub |
There was a problem hiding this comment.
Can this be gated behind isscheduled(sys) so that printing the error doesn't error if the system isn't mtkcompiled? It could also use the string manipulation "hack" discussed earlier in that case (or if the inverse map doesn't have the appropriate entry, as is the case for algebraic variables)
There was a problem hiding this comment.
Shouldn't that error check happen earlier (ie before we get this far in the problem construction). Also note that any variables not in the schedule get passed through as is.
There was a problem hiding this comment.
Problems do not require the system to be mtkcompiled.
Also note that any variables not in the schedule get passed through as is.
Yeah, but we can still print them better.
There was a problem hiding this comment.
this is added back in f137b1a
|
Added the test |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Closes #3913
Add any other context about the problem here.