Skip to content

Conversation

helloeagleyang
Copy link
Contributor

@helloeagleyang helloeagleyang commented Sep 22, 2025

…support

  • upgraded bsp to v1.10.0
  • moved hpm_sdk to rt-thread package
  • added support for hpm6p00evk and hpm5e00evk

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  • 添加hpm6p00evk 和 hpm5e00evk支持
  • 响应社区号召,将hpm_sdk转换成在线包的形式
  • 升级hpm_sdk到v1.10.0

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • HPM6750EVK
  • HPM6750EVKMINI
  • HPM6750EVK2
  • HPM6300EVK
  • HPM6200EVK
  • HPM5300EVK
  • HPM5301EVKLITE
  • HPM6800EVK
  • HPM6E00EVK
  • HPM6P00EVK
  • HPM5E00EVK

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copy link

github-actions bot commented Sep 22, 2025

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-09-23 10:57 CST)

  • Rbb666 Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve labels Sep 22, 2025
@helloeagleyang helloeagleyang force-pushed the feature/update_hpm_bsp_to_v1.10.0 branch 3 times, most recently from d01baa1 to e196cfc Compare September 22, 2025 09:05
@Rbb666 Rbb666 closed this Sep 22, 2025
@Rbb666 Rbb666 reopened this Sep 22, 2025
@Rbb666 Rbb666 requested review from Rbb666 and Copilot September 22, 2025 14:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the HPMicro BSP to SDK v1.10.0, transitions the HPM SDK to an online package format, and adds support for two new evaluation boards (HPM6P00EVK and HPM5E00EVK).

Key changes include:

  • Upgraded HPM SDK from local library to online package format
  • Updated BSP to SDK v1.10.0 with extensive changes to board configurations and startup code
  • Added new board support for HPM6P00EVK and HPM5E00EVK

Reviewed Changes

Copilot reviewed 122 out of 1312 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
bsp/hpmicro/hpm6750evk/board/board.c Updated board initialization, clock configuration, memory management, and removed legacy code
bsp/hpmicro/hpm6750evk/board/SConscript Added cherryusb_port.c to build
bsp/hpmicro/hpm6750evk/SConstruct Removed local HPM SDK integration
bsp/hpmicro/hpm6750evk/.config Added HPM SDK package configuration
Multiple startup files Updated copyright years and fixed linker definitions
Multiple BSP files Converted from local HPM SDK to package-based SDK integration
Comments suppressed due to low confidence (1)

bsp/hpmicro/hpm6200evk/board/linker_scripts/gcc/ram_rtt.ld:1

  • SIZEOF(.fast) is included twice in the calculation, which will result in incorrect load address calculation for the noncacheable init section.
/*

…support

- upgraded bsp to v1.10.0
- moved hpm_sdk to rt-thread package
- added support for hpm6p00evk and hpm5e00evk

Signed-off-by: Fan YANG <[email protected]>
@helloeagleyang helloeagleyang force-pushed the feature/update_hpm_bsp_to_v1.10.0 branch from e196cfc to 78a2be7 Compare September 23, 2025 02:57
@Rbb666 Rbb666 merged commit 35672cd into RT-Thread:master Sep 23, 2025
66 of 67 checks passed
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants