-
Notifications
You must be signed in to change notification settings - Fork 27
feat(ai-gateway): AI Sanitizer support for sanitizing responses #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/gateway-3.12
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
55c9cfe
to
e51b123
Compare
Co-authored-by: 罗泽轩 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a couple suggestions!
port: | ||
description: The sanitizer service's port | ||
value: $SANITIZER_SERVICE_PORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port: | |
description: The sanitizer service's port | |
value: $SANITIZER_SERVICE_PORT |
It's getting mad at the env var because it reads it as a string with the "", so we just have to set a placeholder
anonymize: | ||
- all_and_credentials | ||
sanitization_mode: BOTH | ||
port: ${port} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port: ${port} | |
port: 1111 |
anonymize: | ||
- all_and_credentials | ||
sanitization_mode: OUTPUT | ||
port: ${port} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port: ${port} | |
port: 1111 |
port: | ||
description: The sanitizer service's port | ||
value: $SANITIZER_SERVICE_PORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port: | |
description: The sanitizer service's port | |
value: $SANITIZER_SERVICE_PORT |
Same issue here with the port being interpreted as a string as an env var
1. The PII service detects sensitive data and applies the chosen sanitization method (placeholders or synthetic replacements). | ||
1. If restoration is enabled, the plugin restores the original request data in responses before returning them to the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. The PII service detects sensitive data and applies the chosen sanitization method (placeholders or synthetic replacements). | |
1. If restoration is enabled, the plugin restores the original request data in responses before returning them to the client. | |
1. The PII service detects sensitive data and applies the chosen sanitization method (placeholders or synthetic replacements). | |
1. If restoration is enabled, the plugin restores the original request data in responses before returning them to the client. |
Since I think those also apply to 3.12, I figured rather than call out each with the new_in badge, we could nest these since they're related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step isn't new in 3.12:
- If restoration is enabled, the plugin restores the original request data in responses before returning them to the client.
But the other one is. I can nest that one.
Description
Fixes #2199
INPUT
) is the default, so no config changes need to be made for the original config.Preview Links
https://deploy-preview-2810--kongdeveloper.netlify.app/plugins/ai-sanitizer/
https://deploy-preview-2810--kongdeveloper.netlify.app/plugins/ai-sanitizer/examples/anonymize-request-and-response-data/
https://deploy-preview-2810--kongdeveloper.netlify.app/plugins/ai-sanitizer/examples/anonymize-response-data/
Checklist
description
entry in frontmatter.