Skip to content

{{sory-by}} - Don't sort array when key is empty #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

{{sory-by}} - Don't sort array when key is empty #386

merged 1 commit into from
Nov 9, 2020

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce commented Nov 9, 2020 •
edited
Loading

@GavinJoyce GavinJoyce force-pushed the gj/dont-sort-when-key-is-empty branch from 73527c2 to 19d8888 Compare November 9, 2020 16:03
@GavinJoyce GavinJoyce changed the title failing test - do not sort when key is empty Don't sort array when key is empty Nov 9, 2020
@GavinJoyce GavinJoyce force-pushed the gj/dont-sort-when-key-is-empty branch from 19d8888 to 233a239 Compare November 9, 2020 16:04
@GavinJoyce GavinJoyce changed the title Don't sort array when key is empty {{sory-by}} - Don't sort array when key is empty Nov 9, 2020
@GavinJoyce GavinJoyce changed the title {{sory-by}} - Don't sort array when key is empty [WIP] {{sory-by}} - Don't sort array when key is empty Nov 9, 2020
@GavinJoyce GavinJoyce force-pushed the gj/dont-sort-when-key-is-empty branch from 215239b to 41445ff Compare November 9, 2020 16:19
@GavinJoyce GavinJoyce changed the title [WIP] {{sory-by}} - Don't sort array when key is empty {{sory-by}} - Don't sort array when key is empty Nov 9, 2020
@snewcomer snewcomer added the bug label Nov 9, 2020
snewcomer
snewcomer approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@snewcomer snewcomer merged commit 826d443 into DockYard:master Nov 9, 2020
@GavinJoyce GavinJoyce deleted the gj/dont-sort-when-key-is-empty branch November 9, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@snewcomer snewcomer snewcomer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort order when no key provided has changed between 4.1.1 and 4.3.0
2 participants
@GavinJoyce @snewcomer